From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755Ab3HVKZC (ORCPT ); Thu, 22 Aug 2013 06:25:02 -0400 Received: from m12-17.163.com ([220.181.12.17]:60002 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125Ab3HVKY7 (ORCPT ); Thu, 22 Aug 2013 06:24:59 -0400 Date: Thu, 22 Aug 2013 17:23:23 +0800 From: "=?utf-8?B?bGl1anVubGlhbmdfbGps?=" To: "=?utf-8?B?Sm9lIFBlcmNoZXM=?=" , "=?utf-8?B?aG9ybXM=?=" , "=?utf-8?B?ZGF2ZW0=?=" Cc: "=?utf-8?B?RnJhbmNvaXMgUm9taWV1?=" , "=?utf-8?B?Z3JlZ2to?=" , "=?utf-8?B?c3VuaGVjaGVuZw==?=" , "=?utf-8?B?bGludXgtdXNi?=" , "=?utf-8?B?bmV0ZGV2?=" , "=?utf-8?B?bGludXgta2VybmVs?=" References: <201308201841116403992@163.com>, <20130820204606.GB26241@electric-eye.fr.zoreil.com>, <1377032302.2016.75.camel@joe-AO722>, <201308211807295009698@163.com> Subject: =?utf-8?B?UmU6IFJlOiBSZTogW1BBVENILVNSOTcwMF0gTWVyZ2UgVVNCIDEuMSBFdGhlcm5ldCBBZGFwdGVyIFNSOTcwMERldmljZURyaXZlciBpbnRvIHRoZSBMaW51eCBLZXJuZWw=?= Message-ID: <201308221723223905126@163.com> X-mailer: Foxmail 6, 15, 201, 22 [cn] Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-CM-TRANSID: EcCowEAZE0qJ2BVSzFslAQ--.199S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxXFWUJr4DJr13uFyDJF1DZFb_yoW5Jw47pF WYgFyayF40gF1xZry8Zw1UWa4Fvw1rKasrCryDKasYvF98Ars5Ca40g34UXF15C3yfGF4r ZF4Y9r9xuF4UZ37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jrJ5rUUUUU= X-CM-SenderInfo: xolxy3pqolt0hjboyzi6rwjhhfrp/1tbiqwuBX1EAE0Z-PAAAs5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r7MAP84Z030029 Dear all : Thanks all of you about your attentions and suggestions, and I think firstly I should read the documentations carefully. and then commiting the patch. Thanks all of you for your help and welcome all of you to come to china. Thanks again. 2013-08-22 liujunliang_ljl 发件人： Joe Perches 发送时间： 2013-08-21 19:34:10 收件人： liujunliang_ljl 抄送： Francois Romieu; gregkh; sunhecheng; linux-usb; netdev; linux-kernel 主题： Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700DeviceDriver into the Linux Kernel On Wed, 2013-08-21 at 18:07 +0800, liujunliang_ljl wrote: > Thanks a lot and I have been fixed all the problems mentioned above. please check the following patch and thanks again. Just trivial comments below: > diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c [] > +static void sr_write_reg_async(struct usbnet *dev, u8 reg, u8 value) > +{ > + usbnet_write_cmd_async(dev, SR_WR_REGS, SR_REQ_WR_REG, > + value, reg, NULL, 0); > +} > + > +static int sr_share_read_word(struct usbnet *dev, int phy, u8 reg, __le16 *value) > +{ [] > + netdev_dbg(dev->net, "read shared %d 0x%02x returned 0x%04x, %d\n", > + phy, reg, *value, ret); You have a lot of code that uses inconsistent indentation. Code in drivers/net and drivers/usb/net generally prefers to use alignment to parenthesis for multi-line statements The first could use usbnet_write_cmd_async(dev, SR_WR_REGS, SR_REQ_WR_REG, value, reg, NULL, 0); and the second netdev_dbg(dev->net, "read shared %d 0x%02x returned 0x%04x, %d\n", phy, reg, *value, ret); Maximal use of 8 space indentation tabs followed by minimal spaces. There are many of these above. > +static int sr9700_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data) [] > + for (i = 0; i < eeprom->len / 2; i++) > + ret = sr_read_eeprom_word(dev, eeprom->offset / 2 + i, &ebuf[i]); One too many tabs for the second line, a few of these... [] > +static int sr_mdio_read(struct net_device *netdev, int phy_id, int loc) [] > + if (rc == 1) > + return le16_to_cpu(res) | BMSR_LSTATUS; > + else > + return le16_to_cpu(res) & ~BMSR_LSTATUS; The code below the returns here is unreachable. > + > + netdev_dbg(dev->net, > + "sr_mdio_read() phy_id=0x%02x, loc=0x%02x, returns=0x%04x\n", > + phy_id, loc, le16_to_cpu(res)); > + > + return le16_to_cpu(res); > +} You might try to use scripts/checkpatch.pl --strict if you care about these. It should flag most of these coding style inconsistencies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "=?utf-8?B?bGl1anVubGlhbmdfbGps?=" Subject: =?utf-8?B?UmU6IFJlOiBSZTogW1BBVENILVNSOTcwMF0gTWVyZ2UgVVNCIDEuMSBFdGhlcm5ldCBBZGFwdGVyIFNSOTcwMERldmljZURyaXZlciBpbnRvIHRoZSBMaW51eCBLZXJuZWw=?= Date: Thu, 22 Aug 2013 17:23:23 +0800 Message-ID: <201308221723223905126@163.com> References: <201308201841116403992@163.com>, <20130820204606.GB26241@electric-eye.fr.zoreil.com>, <1377032302.2016.75.camel@joe-AO722>, <201308211807295009698@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "=?utf-8?B?RnJhbmNvaXMgUm9taWV1?=" , "=?utf-8?B?Z3JlZ2to?=" , "=?utf-8?B?c3VuaGVjaGVuZw==?=" , "=?utf-8?B?bGludXgtdXNi?=" , "=?utf-8?B?bmV0ZGV2?=" , "=?utf-8?B?bGludXgta2VybmVs?=" To: "=?utf-8?B?Sm9lIFBlcmNoZXM=?=" , "=?utf-8?B?aG9ybXM=?=" , "=?utf-8?B?ZGF2ZW0=?=" Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org RGVhciBhbGwgOg0KDQoJCVRoYW5rcyBhbGwgb2YgeW91IGFib3V0IHlvdXIgYXR0ZW50aW9ucyBh bmQgc3VnZ2VzdGlvbnMsIGFuZCBJIHRoaW5rIGZpcnN0bHkgSSBzaG91bGQgcmVhZCB0aGUgZG9j dW1lbnRhdGlvbnMgY2FyZWZ1bGx5Lg0KDQoJCWFuZCB0aGVuIGNvbW1pdGluZyB0aGUgcGF0Y2gu IA0KDQoJCVRoYW5rcyBhbGwgb2YgeW91IGZvciB5b3VyIGhlbHAgYW5kIHdlbGNvbWUgYWxsIG9m IHlvdSB0byBjb21lIHRvIGNoaW5hLg0KDQoJCVRoYW5rcyBhZ2Fpbi4NCg0KDQoNCjIwMTMtMDgt MjIgDQoNCg0KDQpsaXVqdW5saWFuZ19samwgDQoNCg0KDQrlj5Hku7bkurrvvJogSm9lIFBlcmNo ZXMgDQrlj5HpgIHml7bpl7TvvJogMjAxMy0wOC0yMSAgMTk6MzQ6MTAgDQrmlLbku7bkurrvvJog bGl1anVubGlhbmdfbGpsIA0K5oqE6YCB77yaIEZyYW5jb2lzIFJvbWlldTsgZ3JlZ2toOyBzdW5o ZWNoZW5nOyBsaW51eC11c2I7IG5ldGRldjsgbGludXgta2VybmVsIA0K5Li76aKY77yaIFJlOiBS ZTogW1BBVENILVNSOTcwMF0gTWVyZ2UgVVNCIDEuMSBFdGhlcm5ldCBBZGFwdGVyIFNSOTcwMERl dmljZURyaXZlciBpbnRvIHRoZSBMaW51eCBLZXJuZWwgDQogDQpPbiBXZWQsIDIwMTMtMDgtMjEg YXQgMTg6MDcgKzA4MDAsIGxpdWp1bmxpYW5nX2xqbCB3cm90ZToNCj4gIFRoYW5rcyBhIGxvdCBh bmQgSSBoYXZlIGJlZW4gZml4ZWQgYWxsIHRoZSBwcm9ibGVtcyBtZW50aW9uZWQgYWJvdmUuIHBs ZWFzZSBjaGVjayB0aGUgZm9sbG93aW5nIHBhdGNoIGFuZCB0aGFua3MgYWdhaW4uIA0KSnVzdCB0 cml2aWFsIGNvbW1lbnRzIGJlbG93Og0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvdXNiL3Ny OTcwMC5jIGIvZHJpdmVycy9uZXQvdXNiL3NyOTcwMC5jDQpbXQ0KPiArc3RhdGljIHZvaWQgc3Jf d3JpdGVfcmVnX2FzeW5jKHN0cnVjdCB1c2JuZXQgKmRldiwgdTggcmVnLCB1OCB2YWx1ZSkNCj4g K3sNCj4gKyB1c2JuZXRfd3JpdGVfY21kX2FzeW5jKGRldiwgU1JfV1JfUkVHUywgU1JfUkVRX1dS X1JFRywNCj4gKyB2YWx1ZSwgcmVnLCBOVUxMLCAwKTsNCj4gK30NCj4gKw0KPiArc3RhdGljIGlu dCBzcl9zaGFyZV9yZWFkX3dvcmQoc3RydWN0IHVzYm5ldCAqZGV2LCBpbnQgcGh5LCB1OCByZWcs IF9fbGUxNiAqdmFsdWUpDQo+ICt7DQpbXQ0KPiArIG5ldGRldl9kYmcoZGV2LT5uZXQsICJyZWFk IHNoYXJlZCAlZCAweCUwMnggcmV0dXJuZWQgMHglMDR4LCAlZFxuIiwNCj4gKyAgICAgICAgcGh5 LCByZWcsICp2YWx1ZSwgcmV0KTsNCllvdSBoYXZlIGEgbG90IG9mIGNvZGUgdGhhdCB1c2VzIGlu Y29uc2lzdGVudA0KaW5kZW50YXRpb24uICBDb2RlIGluIGRyaXZlcnMvbmV0IGFuZCBkcml2ZXJz L3VzYi9uZXQNCmdlbmVyYWxseSBwcmVmZXJzIHRvIHVzZSBhbGlnbm1lbnQgdG8gcGFyZW50aGVz aXMgZm9yDQptdWx0aS1saW5lIHN0YXRlbWVudHMNClRoZSBmaXJzdCBjb3VsZCB1c2UNCnVzYm5l dF93cml0ZV9jbWRfYXN5bmMoZGV2LCBTUl9XUl9SRUdTLCBTUl9SRVFfV1JfUkVHLA0KICAgICAg IHZhbHVlLCByZWcsIE5VTEwsIDApOw0KYW5kIHRoZSBzZWNvbmQNCm5ldGRldl9kYmcoZGV2LT5u ZXQsICJyZWFkIHNoYXJlZCAlZCAweCUwMnggcmV0dXJuZWQgMHglMDR4LCAlZFxuIiwNCiAgIHBo eSwgcmVnLCAqdmFsdWUsIHJldCk7DQpNYXhpbWFsIHVzZSBvZiA4IHNwYWNlIGluZGVudGF0aW9u IHRhYnMgZm9sbG93ZWQgYnkNCm1pbmltYWwgc3BhY2VzLg0KVGhlcmUgYXJlIG1hbnkgb2YgdGhl c2UgYWJvdmUuDQo+ICtzdGF0aWMgaW50IHNyOTcwMF9nZXRfZWVwcm9tKHN0cnVjdCBuZXRfZGV2 aWNlICpuZXQsIHN0cnVjdCBldGh0b29sX2VlcHJvbSAqZWVwcm9tLCB1OCAqZGF0YSkNCltdDQo+ ICsgZm9yIChpID0gMDsgaSA8IGVlcHJvbS0+bGVuIC8gMjsgaSsrKQ0KPiArIHJldCA9IHNyX3Jl YWRfZWVwcm9tX3dvcmQoZGV2LCBlZXByb20tPm9mZnNldCAvIDIgKyBpLCAmZWJ1ZltpXSk7DQpP bmUgdG9vIG1hbnkgdGFicyBmb3IgdGhlIHNlY29uZCBsaW5lLCBhIGZldyBvZiB0aGVzZS4uLg0K W10NCj4gK3N0YXRpYyBpbnQgc3JfbWRpb19yZWFkKHN0cnVjdCBuZXRfZGV2aWNlICpuZXRkZXYs IGludCBwaHlfaWQsIGludCBsb2MpDQpbXQ0KPiArIGlmIChyYyA9PSAxKQ0KPiArIHJldHVybiBs ZTE2X3RvX2NwdShyZXMpIHwgQk1TUl9MU1RBVFVTOw0KPiArIGVsc2UNCj4gKyByZXR1cm4gbGUx Nl90b19jcHUocmVzKSAmIH5CTVNSX0xTVEFUVVM7DQpUaGUgY29kZSBiZWxvdyB0aGUgcmV0dXJu cyBoZXJlIGlzIHVucmVhY2hhYmxlLg0KPiArDQo+ICsgbmV0ZGV2X2RiZyhkZXYtPm5ldCwNCj4g KyAgICAgICAgInNyX21kaW9fcmVhZCgpIHBoeV9pZD0weCUwMngsIGxvYz0weCUwMngsIHJldHVy bnM9MHglMDR4XG4iLA0KPiArICAgICAgICBwaHlfaWQsIGxvYywgbGUxNl90b19jcHUocmVzKSk7 DQo+ICsNCj4gKyByZXR1cm4gbGUxNl90b19jcHUocmVzKTsNCj4gK30NCllvdSBtaWdodCB0cnkg dG8gdXNlIHNjcmlwdHMvY2hlY2twYXRjaC5wbCAtLXN0cmljdCBpZiB5b3UNCmNhcmUgYWJvdXQg dGhlc2UuICBJdCBzaG91bGQgZmxhZyBtb3N0IG9mIHRoZXNlIGNvZGluZw0Kc3R5bGUgaW5jb25z aXN0ZW5jaWVzLg0K