Re: [PATCH 3/3] fork: unify and tighten up CLONE_NEWUSER/CLONE_NEWPID checks

[Oleg Nesterov <oleg@redhat.com>]

On 08/22, Andy Lutomirski wrote:
>
> On Thu, Aug 22, 2013 at 11:15 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Yes. Before this patch do_fork() did:
> >
> >         if (clone_flags & (CLONE_NEWUSER | CLONE_NEWPID)) {
> >                 if (clone_flags & (CLONE_THREAD|CLONE_PARENT))
> >                         return -EINVAL;
> >         }
> >
> > however, let me repeat, CLONE_PARENT after unshare(CLONE_NEWPID) was
> > allowed. With this patch CLONE_PARENT is nacked in both cases.
>
> Is this -stable-worthy?

Honestly, I do not know. I do not want to abuse -stable, and I will
sleep better if this patch won't go into the stable trees ;)

OTOH, I think that at least 1/3 is probably -stable material... Since
I am going to send v2, I would not mind to add stable@vger.kernel.org
if both you and Eric agree.

Oleg.