From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 50FC4E005B4 for ; Fri, 23 Aug 2013 00:05:47 -0700 (PDT) Received: from e6520eb (unknown [88.170.243.169]) (Authenticated sender: eukrea) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 9C4974B004B; Fri, 23 Aug 2013 09:05:35 +0200 (CEST) Date: Fri, 23 Aug 2013 09:05:34 +0200 From: Eric =?ISO-8859-1?B?QuluYXJk?= To: Alexandre Belloni Message-ID: <20130823090534.7ca3df3d@e6520eb> In-Reply-To: <52169966.5020607@free-electrons.com> References: <1377183077-5270-1-git-send-email-alexandre.belloni@free-electrons.com> <1377183077-5270-2-git-send-email-alexandre.belloni@free-electrons.com> <20130822191421.53fd6f95@e6520eb> <52169966.5020607@free-electrons.com> Organization: =?ISO-8859-1?B?RXVrculh?= Electromatique X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Cc: "meta-freescale@yoctoproject.org" , brian@crystalfontz.com, Maxime Ripard , jimwall@q.com, Otavio Salvador Subject: Re: [meta-fsl-arm-extra][PATCH 1/4] barebox: add a recipe to support mainline 2013.08.0 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2013 07:05:52 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Alexandre, Le Fri, 23 Aug 2013 01:06:14 +0200, Alexandre Belloni a =E9crit : > On 22/08/2013 20:00, Otavio Salvador wrote: > > On Thu, Aug 22, 2013 at 2:14 PM, Eric B=E9nard wrote: > >> Hi Alexandre, > >> > >> Le Thu, 22 Aug 2013 16:51:14 +0200, > >> Alexandre Belloni a =E9crit : > >> > >>> Signed-off-by: Alexandre Belloni > >>> --- > >>> recipes-bsp/barebox/barebox_2013.08.0.bb | 26 ++++++++++++++++++++++= ++++ > >>> 1 file changed, 26 insertions(+) > >>> create mode 100644 recipes-bsp/barebox/barebox_2013.08.0.bb > >>> > >>> diff --git a/recipes-bsp/barebox/barebox_2013.08.0.bb b/recipes-bsp/b= arebox/barebox_2013.08.0.bb > >>> new file mode 100644 > >>> index 0000000..2f6118b > >>> --- /dev/null > >>> +++ b/recipes-bsp/barebox/barebox_2013.08.0.bb > >>> @@ -0,0 +1,26 @@ > >>> +require recipes-bsp/barebox/barebox.inc > >>> + > >>> +PR =3D "r1" > >>> + > >>> +SRC_URI =3D "http://barebox.org/download/${PN}-${PV}.tar.bz2" > >>> + > >>> +SRC_URI[md5sum] =3D "a61b97a2fedebc808d4b182c2ca18a0c" > >>> +SRC_URI[sha256sum] =3D "d9e46dd3c68b04ab4cbc37135dc34907dbebef393da4= b3e54abb203c295c1620" > >>> + > >>> +python () { > >>> + if not d.getVar("BAREBOX_MACHINE", True): > >>> + PN =3D d.getVar("PN", True) > >>> + FILE =3D os.path.basename(d.getVar("FILE", True)) > >>> + bb.debug(1, "To build %s, see %s for instructions on \ > >>> + setting up your machine config" % (PN, FIL= E)) > >>> + raise bb.parse.SkipPackage("BAREBOX_MACHINE is not set = in the %s machine configuration." % d.getVar("MACHINE", True)) > >>> +} > >>> + > >> if you plan to create a generic barebox recipe and as barebox is using > >> Kconfig like Linux does, I would recommend to include the defconfig for > >> your board here as done on the kernel side instead of using the > >> defconfig which may exist into barebox's mainline sources (that makes > >> customization easier especially when using SOM). > >> > >> If you don't plan do create the generic barebox recipe, that's still on > >> my todo list but with a very low priority :-) > > Agreed. > > > I'm actually wondering about that. The defconfig included in the barebox > mainline is perfectly fine. And people wanting to change it will have to > write a bbappend anyway or am I missing something ? a bbappend will be needed but in that case the python () which skips the package if BAREBOX_MACHINE is not set shouldn't go in the default barebox recipe else every machine using barebox will have to set BAREBOX_MACHINE and then to hack the defconfig after pre_configure. Eric