From: Dan Carpenter <dan.carpenter@oracle.com>
To: navin patidar <navinp@cdac.in>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
maxtram95@gmail.com, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter
Date: Fri, 23 Aug 2013 14:48:18 +0300 [thread overview]
Message-ID: <20130823114818.GU22811@mwanda> (raw)
In-Reply-To: <1377257406-16787-1-git-send-email-navinp@cdac.in>
On Fri, Aug 23, 2013 at 05:00:06PM +0530, navin patidar wrote:
> struct pt_regs pointer is no longer passed as a irq handler
> argument.
>
Good eye.
Could you also remove the cast to (void *) so the compiler can catch
this in the future?
- if (request_irq(dev->irq, (void *)rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
+ if (request_irq(dev->irq, rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
regrds,
dan carpenter
next prev parent reply other threads:[~2013-08-23 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 11:30 [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter navin patidar
2013-08-23 11:48 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-23 12:19 navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823114818.GU22811@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=navinp@cdac.in \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.