From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH -next] staging: lustre: Use proper constant types for L*_POISON values Date: Fri, 23 Aug 2013 10:21:02 -0700 Message-ID: <20130823172102.GA20400@kroah.com> References: <1377272808-21686-1-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1377272808-21686-1-git-send-email-geert@linux-m68k.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Geert Uytterhoeven Cc: devel@driverdev.osuosl.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-next.vger.kernel.org T24gRnJpLCBBdWcgMjMsIDIwMTMgYXQgMDU6NDY6NDhQTSArMDIwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IE9uIDMyLWJpdCBtNjhrLCBJIGdldCBsb3RzIG9mIHdhcm5pbmdzIGxpa2U6 Cj4gCj4gICAgIHdhcm5pbmc6IGludGVnZXIgY29uc3RhbnQgaXMgdG9vIGxhcmdlIGZvciDigJhs b25n4oCZIHR5cGUKPiAKPiBTd2l0Y2ggdGhlIEwqX1BPSVNPTiBkZWZpbml0aW9ucyBmcm9tIHRv by1sYXJnZSBjb25zdGFudHMgYW5kIGNhc3RzCj4gdG8gdGhlIHByb3BlciBjb25zdGFudCB0eXBl cyB0byBmaXggdGhpcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBHZWVydCBVeXR0ZXJob2V2ZW4gPGdl ZXJ0QGxpbnV4LW02OGsub3JnPgo+IC0tLQo+IFRoZSB2YWx1ZXMgaW4gZHJpdmVycy9zdGFnaW5n L2x1c3RyZS9sdXN0cmUvaW5jbHVkZS9saW51eC9sdXN0cmVfbGliLmgKPiBkb24ndCBzZWVtIHRv IGJlIHVzZWQsIGFzIExQX1BPSVNPTiBpcyBhbHJlYWR5IGRlZmluZWQgYXQgdGhhdCBwb2ludD8K ClByb2JhYmx5LiAgSSBkb24ndCBzZWUgd2hlcmUgYW55b25lIGV2ZW4gdXNlcyB0aGVzZSAicG9p c29uIiB2YWx1ZXMsCmV4Y2VwdCB0byBjaGVjayB2YXJpYWJsZXMgdG8gZW5zdXJlIHRoZXkgZG9u J3QgY29udGFpbiB0aGUgdmFsdWUsIHdoaWNoCmlzIGFsd2F5cyBnb2luZyB0byBiZSB0cnVlIGFz IG5vIG9uZSBzZXRzIHRoZW0uCgpPaCB3ZWxsLCBtb3JlIGRlYWQgY29kZSBpbiB0aGUgZHJpdmVy LCBub3RoaW5nIG5ldy4uLgoKdGhhbmtzLAoKZ3JlZyBrLWgKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4 ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755692Ab3HWRVG (ORCPT ); Fri, 23 Aug 2013 13:21:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58790 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754542Ab3HWRVD (ORCPT ); Fri, 23 Aug 2013 13:21:03 -0400 Date: Fri, 23 Aug 2013 10:21:02 -0700 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: devel@driverdev.osuosl.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] staging: lustre: Use proper constant types for L*_POISON values Message-ID: <20130823172102.GA20400@kroah.com> References: <1377272808-21686-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1377272808-21686-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 23, 2013 at 05:46:48PM +0200, Geert Uytterhoeven wrote: > On 32-bit m68k, I get lots of warnings like: > > warning: integer constant is too large for ‘long’ type > > Switch the L*_POISON definitions from too-large constants and casts > to the proper constant types to fix this. > > Signed-off-by: Geert Uytterhoeven > --- > The values in drivers/staging/lustre/lustre/include/linux/lustre_lib.h > don't seem to be used, as LP_POISON is already defined at that point? Probably. I don't see where anyone even uses these "poison" values, except to check variables to ensure they don't contain the value, which is always going to be true as no one sets them. Oh well, more dead code in the driver, nothing new... thanks, greg k-h