Re: (XEN) [2013-08-23 12:23:26] Assertion 'entry->pirq == pirq' failed at vmsi.c

[Joby Poriyath <joby.poriyath@citrix.com>]

On Fri, Aug 23, 2013 at 02:55:32PM +0100, Jan Beulich wrote:
> >>> On 23.08.13 at 15:26, Sander Eikelenboom <linux@eikelenboom.it> wrote:
> > I have adjusted the debug patch, only letting it reuse the entry if ( pdev 
> > == entry->pdev && entry->pirq == pirq){
> > so the assertion should be always true now, would this perhaps be the proper 
> > fix or should it also check if it is also masked ?
> 
> Yes, that might be a possible solution, albeit I don't like it - it points
> out that the original patch from Joby is - beyond the bug here - at
> least inefficient (in that we'd then allocate an entry per MSI-X table
> entry, i.e. per IRQ, instead of per device). I therefore think we
> rather ought to revert that change, and have him redo it properly.

Ok, we ought to revisit the original patch. Let us revert the code for now.

Thanks Sander for spotting this.
It's a certainly an oversight from my side.

A PCIe function can have multiple MSIx entries.

I'm on holidays. I'll be back on 29th Aug. I shall pick this up, then.

Thanks,
Joby