All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Leon Ma <xindong.ma@intel.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	dan.carpenter@oracle.com, ccross@android.com
Subject: Re: [PATCH] LMK: Optimize lowmem_shrink
Date: Sat, 24 Aug 2013 00:20:21 +0300	[thread overview]
Message-ID: <20130823212021.GA2248@swordfish.minsk.epam.com> (raw)
In-Reply-To: <20130823164810.GA25863@kroah.com>

On (08/23/13 09:48), Greg KH wrote:
> Subject: Re: [PATCH] LMK: Optimize lowmem_shrink
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> On Wed, Aug 21, 2013 at 09:41:05AM +0800, Leon Ma wrote:
> > From: Leon Ma <xindong.ma@intel.com>
> > Date: Mon, 19 Aug 2013 14:22:38 +0800
> > Subject: [PATCH] LMK: Optimize lowmem_shrink.
> 
> Why is all of this in the patch body?
> 
> And what does "LMK:" stand for?
>
> > By comparing with selected_oom_score_adj instead of min_score_adj,
> > we may do less calculation.
> 
> What does this change?  Does it fix a problem?

Hello,

linux-next since

	c95dd63d4cc3647643ff502d70c4c1b52947c770
	Author: Dave Chinner <dchinner@redhat.com>
	Date:   Fri Aug 16 09:39:54 2013 +1000

	drivers: convert shrinkers to new count/scan API

does not contain lowmem_shrink(), but lowmem_scan() instead. plus at lest
one more patch on top of it (e2bfaf75e763396b7baa7c1effa4053d7f19e6d3):

[..]
-static int lowmem_shrink(struct shrinker *s, struct shrink_control *sc)

+static long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
[..]

wouldn't it be better to have the patch against -next in this case (in
case it fixes anything)?

thanks,
	-ss

> thanks,
> 
> greg k-h
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

  reply	other threads:[~2013-08-23 21:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  1:41 [PATCH] LMK: Optimize lowmem_shrink Leon Ma
2013-08-23 16:48 ` Greg KH
2013-08-23 21:20   ` Sergey Senozhatsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-08-20  1:16 Leon Ma
2013-08-20  2:23 ` Colin Cross
2013-08-20  2:25   ` Colin Cross
2013-08-20  8:30 ` Dan Carpenter
2013-08-21  2:09   ` Ma, Xindong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130823212021.GA2248@swordfish.minsk.epam.com \
    --to=sergey.senozhatsky@gmail.com \
    --cc=ccross@android.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xindong.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.