From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.
Date: Sun, 25 Aug 2013 11:17:12 +0200 [thread overview]
Message-ID: <20130825111712.6a96f399@skate> (raw)
In-Reply-To: <1377299653-9977-1-git-send-email-sagaert.johan@skynet.be>
Dear Sagaert Johan,
On Sat, 24 Aug 2013 01:14:13 +0200, Sagaert Johan wrote:
> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
> ---
> package/qt/Config.in | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 35e8208..2541875 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -264,7 +264,8 @@ source "package/qt/Config.keyboard.in"
>
> config BR2_PACKAGE_QT_PHONON
> bool "Phonon Module"
> - depends on BR2_PACKAGE_GSTREAMER
> + depends on BR2_PACKAGE_GSTREAMER
> + depends on BR2_PACKAGE_LIBGLIB2
Hum, I'm not sure to understand. BR2_PACKAGE_QT_PHONON already depends
on BR2_PACKAGE_GSTREAMER. And BR2_PACKAGE_GSTREAMER selects
BR2_PACKAGE_LIBGLIB2. So, if BR2_PACKAGE_GSTREAMER is enabled, then
you're sure BR2_PACKAGE_LIBGLIB2 is enabled.
So unless I'm missing something, your patch does nothing, and I don't
quite see how it could fix any issue. Can you give the .config that
exhibits your build problem?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-25 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 23:14 [Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail Sagaert Johan
2013-08-25 9:17 ` Thomas Petazzoni [this message]
2013-08-25 15:01 ` Sagaert Johan
2013-08-26 8:21 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130825111712.6a96f399@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.