Re: [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION and AUTOREV

[Denys Dmytriyenko <denys@ti.com>]

On Fri, Aug 23, 2013 at 09:54:44PM +0000, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Friday, August 23, 2013 4:15 PM
> > To: Cooper Jr., Franklin
> > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable LOCALVERSION
> > and AUTOREV
> > 
> > On Fri, Aug 23, 2013 at 09:08:06PM +0000, Cooper Jr., Franklin wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > > Sent: Friday, August 23, 2013 4:04 PM
> > > > To: meta-arago@arago-project.org
> > > > Subject: [meta-arago] [PATCHv2 3/4] linux-ti-staging: enable
> > > > LOCALVERSION and AUTOREV
> > > >
> > > > From: Denys Dmytriyenko <denys@ti.com>
> > > >
> > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > ---
> > > > v2 - removed the comment about upstreaming LOCALVERSION, may not
> > > > happen
> > > >
> > > >  .../recipes-kernel/linux/linux-ti-staging_git.bbappend  | 17
> > > > +++++++++++++++++
> > > >  1 file changed, 17 insertions(+)
> > > >  create mode 100644 meta-arago-distro/recipes-kernel/linux/linux-ti-
> > > > staging_git.bbappend
> > > >
> > > > diff --git
> > > > a/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappe
> > > > nd
> > > > b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bbappe
> > > > nd
> > > > new file mode 100644
> > > > index 0000000..f99482c
> > > > --- /dev/null
> > > > +++ b/meta-arago-distro/recipes-kernel/linux/linux-ti-staging_git.bb
> > > > +++ append
> > > > @@ -0,0 +1,17 @@
> > > > +MACHINE_KERNEL_PR_append = "-arago0"
> > > > +
> > > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${P}:"
> > > > +
> > > > +require copy-defconfig.inc
> > 
> > > [Franklin] Are we really planning on have different defconfigs for
> > > each machine? I thought with DT all machines will share the same defconfig.
> > 
> > Yes, linux-ti-staging uses a blank defconfig that points to omap2plus_defconfig.
> > 
> > But copy-defconfig just saves the current config for SDK use - they will be the
> > same for machines using this recipe. But still, there are currently only 2 OMAP
> > machines supported by this kernel and will be 2 Sitara machines with this
> > patchset. If/when we switch remaining SDK machines to use the latest kernel,
> > we can revisit this matter, I guess.
> [Franklin] 
> I guess my point was that copy-defconfig.inc renames the .config to 
> tisdk_${MACHINE}_defconfig. Can we set CONFIG_NAME to "omap2plus_defconfig" 
> since we should stick with that defconfig name for all machines?

And what I was trying to say before, is that "all machines" is currently only 2 
out of several and even then, omap2plus_defconfig in the kernel may not match 
exactly the one produced by the SDK - there may be some mangling involved to 
adjust some config options to sane defaults (although we no longer include 
linux.inc with that code), plus we run "make oldconfig" on it, which checks 
dependecies between config options and may change some os them. In other 
words: omap2plus_defconfig != .config which we package in the SDK. It is like 
the difference between pristine sources and sources that were patched and 
configured...

-- 
Denys


> > > > +SRCREV = "${AUTOREV}"
> > > > +
> > > > +KERNEL_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > > > True).partition('+')[2][0:7]}"
> > > > +
> > > > +kernel_do_configure_prepend() {
> > > > +    if [ ! -e ${B}/.scmversion -a ! -e ${S}/.scmversion ]
> > > > +    then
> > > > +        echo ${KERNEL_LOCALVERSION} > ${B}/.scmversion
> > > > +        echo ${KERNEL_LOCALVERSION} > ${S}/.scmversion
> > > > +    fi
> > > > +}
> > > > --
> > > > 1.8.3.2
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>