From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDzRs-0002L2-T2 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 12:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDzRm-00032d-Mf for qemu-devel@nongnu.org; Mon, 26 Aug 2013 12:15:24 -0400 Date: Mon, 26 Aug 2013 19:17:13 +0300 From: "Michael S. Tsirkin" Message-ID: <20130826161712.GA23449@redhat.com> References: <1376344938-21374-1-git-send-email-pbonzini@redhat.com> <521B483D.9090203@redhat.com> <521B6775.5060102@suse.de> <521B6DCB.9030505@redhat.com> <521B7173.1030505@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <521B7173.1030505@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-stable@nongnu.org On Mon, Aug 26, 2013 at 05:17:07PM +0200, Andreas F=E4rber wrote: > Am 26.08.2013 17:01, schrieb Paolo Bonzini: > > Il 26/08/2013 16:34, Andreas F=E4rber ha scritto: > >> Am 26.08.2013 14:21, schrieb Paolo Bonzini: > >>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto: > >>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not > >>>> possible without PAM hardware. This fixes a segmentation fault > >>>> running with -M isapc. > >>>> > >>>> Cc: qemu-stable@nongnu.org > >>>> Signed-off-by: Paolo Bonzini > >>>> --- > >>>> > >>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > >>>> index a19e172..3aa244a 100644 > >>>> --- a/hw/i386/pc_piix.c > >>>> +++ b/hw/i386/pc_piix.c > >>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine =3D { > >>>> .init =3D pc_init_isa, > >>>> .max_cpus =3D 1, > >>>> .compat_props =3D (GlobalProperty[]) { > >>>> + { > >>>> + .driver =3D "apic-common", > >>>> + .property =3D "kvmvapic", > >>>> + .value =3D "off", > >>>> + }, > >>>> { /* end of list */ } > >>>> }, > >>>> DEFAULT_MACHINE_OPTIONS, > >>>> > >>> > >>> Ping. > >> > >> I had double-checked that my pending qom-test covers isapc and succe= eds > >> with and without your patch, so apparently this is visible at runtim= e only. > >=20 > > Yes, it only happens after kvmvapic is actually enabled by the option= ROM. >=20 > Maybe Michael can pick it up along with the compat refactorings? >=20 > Andreas Sure, I'll put it on my tree but I already prepared a pull request for today, it will go into the next one. > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg