From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 7/8] ASoC: Move call to snd_soc_dapm_new_widgets() after snd_soc_dapm_auto_nc_codec_pins()
Date: Tue, 27 Aug 2013 15:41:27 +0100 [thread overview]
Message-ID: <20130827144127.GS10783@sirena.org.uk> (raw)
In-Reply-To: <1377611461-3638-7-git-send-email-lars@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]
On Tue, Aug 27, 2013 at 03:51:00PM +0200, Lars-Peter Clausen wrote:
> Call snd_soc_dapm_new_widgets() before the auto non-connected pins have been
> marked as not connected will power the system under the assumption that those
> pins are connected. Once the pins have been marked as disconnected the system
> there will be an additional power run. This can cause unnecessary power
> transitions. Calling snd_soc_dapm_new_widgets() only after the pins have been
> marked as non-connected avoids this.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-08-27 14:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 13:50 [PATCH 1/8] ASoC: dapm: Fix marking widgets dirty when a route is added Lars-Peter Clausen
2013-08-27 13:50 ` [PATCH 2/8] ASoC: dmic: Convert table based DAPM setup Lars-Peter Clausen
2013-08-27 14:32 ` Mark Brown
2013-08-27 13:50 ` [PATCH 3/8] ASoC: tlv320aic32x4: Convert table based control and " Lars-Peter Clausen
2013-08-27 14:35 ` Mark Brown
2013-08-27 14:41 ` Lars-Peter Clausen
2013-08-27 14:54 ` Mark Brown
2013-08-27 13:50 ` [PATCH 4/8] ASoC; wm8904: Remove unnecessary call to snd_soc_dapm_new_widgets() Lars-Peter Clausen
2013-08-27 14:36 ` Mark Brown
2013-08-27 13:50 ` [PATCH 5/8] ASoC: jack: " Lars-Peter Clausen
2013-08-27 14:37 ` Mark Brown
2013-08-27 13:50 ` [PATCH 6/8] ASoC: Call snd_soc_dapm_new_widgets() only once during card initialization Lars-Peter Clausen
2013-08-27 14:38 ` Mark Brown
2013-08-27 13:51 ` [PATCH 7/8] ASoC: Move call to snd_soc_dapm_new_widgets() after snd_soc_dapm_auto_nc_codec_pins() Lars-Peter Clausen
2013-08-27 14:41 ` Mark Brown [this message]
2013-08-27 13:51 ` [PATCH 8/8] ASoC: Pass card instead of dapm context to snd_soc_dapm_new_widgets() Lars-Peter Clausen
2013-08-27 14:42 ` Mark Brown
2013-08-27 14:33 ` [PATCH 1/8] ASoC: dapm: Fix marking widgets dirty when a route is added Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827144127.GS10783@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.