From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst
Date: Tue, 27 Aug 2013 15:27:41 +0000 [thread overview]
Message-ID: <20130827152741.GA15030@roeck-us.net> (raw)
In-Reply-To: <1376299240-26943-1-git-send-email-sachin.kamat@linaro.org>
On Mon, Aug 12, 2013 at 02:50:40PM +0530, Sachin Kamat wrote:
> __initconst should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Luca Tettamanti <kronos.it@gmail.com>
> ---
> drivers/hwmon/asus_atk0110.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index b25c643..9ddadb3 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -29,7 +29,7 @@ static bool new_if;
> module_param(new_if, bool, 0);
> MODULE_PARM_DESC(new_if, "Override detection heuristic and force the use of the new ATK0110 interface");
>
> -static const struct dmi_system_id __initconst atk_force_new_if[] = {
> +static const struct dmi_system_id atk_force_new_if[] __initconst = {
> {
> /* Old interface has broken MCH temp monitoring */
> .ident = "Asus Sabertooth X58",
Based on the other discussion we just had, this patch is unnecessary.
I will therefore drop it from my queue.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2013-08-27 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 9:32 [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst Sachin Kamat
2013-08-12 11:18 ` Guenter Roeck
2013-08-27 15:27 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827152741.GA15030@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.