From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH RFC 2/2] linux/vnuma: Enables NUMA support
 for	PV guest
Date: Tue, 27 Aug 2013 11:36:51 -0400
Message-ID: <20130827153651.GA5064@phenom.dumpdata.com>
References: <1377593580-10040-1-git-send-email-ufimtseva@gmail.com>
	<1377593580-10040-3-git-send-email-ufimtseva@gmail.com>
	<521CAB16.6000308@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <521CAB16.6000308@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Elena Ufimtseva <ufimtseva@gmail.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Aug 27, 2013 at 02:35:18PM +0100, David Vrabel wrote:
> On 27/08/13 09:53, Elena Ufimtseva wrote:
> > Enables NUMA support for PV guest and uses vNUMA
> > interface to discover topology provided by XEN.
> > 
> > Signed-off-by: Elena Ufimtseva <ufimtseva@gmail.com>
> > ---
> >  arch/x86/xen/setup.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> > index 056d11f..7e0c93b 100644
> > --- a/arch/x86/xen/setup.c
> > +++ b/arch/x86/xen/setup.c
> > @@ -561,6 +561,6 @@ void __init xen_arch_setup(void)
> >  	WARN_ON(xen_set_default_idle());
> >  	fiddle_vdso();
> >  #ifdef CONFIG_NUMA
> > -	numa_off = 1;
> > +	numa_off = 0;
> >  #endif
> >  }
> 
> Hmm. This is either safe to turn on now or it will break on hosts
> without vNUMA support as it will cause a fallback to try all the
> hardware specific NUMA initialization.
> 
> Which is it?

It will blow up when booting as dom0 on certain AMD machines.

> 
> David
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel