All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [1/1] civetweb: new package
Date: Tue, 27 Aug 2013 16:29:34 +0200	[thread overview]
Message-ID: <20130827162934.3f2a4333@skate> (raw)
In-Reply-To: <CAAXf6LX52MBd8Lrp4eho=Vkdo=QVyZ4=aytMJu3dY6w0EwoJkA@mail.gmail.com>

Thomas, Thomas,

On Tue, 27 Aug 2013 16:27:39 +0200, Thomas De Schampheleire wrote:

> > +$(eval $(generic-package))
> > \ No newline at end of file
> 
> There is no newline at the end of your .mk file, this should be fixed too.

And also generally speaking, the patch should be sent using 'git
send-email', because HTML formatted patches that are line wrapped are
not really practical to be applied on Buildroot.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-08-27 14:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 13:32 [Buildroot] [1/1] civetweb: new package Thomas Davis
2013-08-27 14:27 ` Thomas De Schampheleire
2013-08-27 14:29   ` Thomas Petazzoni [this message]
2013-08-27 14:56     ` Thomas Davis
     [not found]     ` <CAG3-AMraW=os9fWHuukfn_poxQvwPGJ7OGshb3y66TYdCgSVFA@mail.gmail.com>
2013-08-27 15:43       ` Thomas Petazzoni
2013-08-27 20:12     ` Thomas De Schampheleire
2013-08-27 20:51       ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2013-08-27 17:57 Thomas Davis
2013-08-27 18:39 ` Thomas Petazzoni
2013-08-27 18:54   ` Thomas Davis
2013-08-27 19:15     ` Thomas Petazzoni
2013-08-27 19:28       ` Thomas Davis
2013-08-27 20:50         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827162934.3f2a4333@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.