All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Hilman <khilman@linaro.org>
Cc: Alexander Savchenko <oleksandr.savchenko@ti.com>,
	jslaby@suse.cz, linux-serial@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	balbi@ti.com, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] serial: omap: Fix IRQ handling return value
Date: Tue, 27 Aug 2013 10:38:19 -0700	[thread overview]
Message-ID: <20130827173819.GD21564@kroah.com> (raw)
In-Reply-To: <CAGa+x859+7H3pjZfTFcECe4qMt4=SE_kmToZBt9zoVt0=sUcvA@mail.gmail.com>

On Tue, Aug 27, 2013 at 07:30:19AM -0700, Kevin Hilman wrote:
> Greg,
> 
> 
> On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman <khilman@linaro.org> wrote:
> > +Felipe
> >
> > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> > <oleksandr.savchenko@ti.com> wrote:
> >> From: Ruchika Kharwar <ruchika@ti.com>
> >>
> >> Ensure the Interrupt handling routine return IRQ_HANDLED vs
> >> IRQ_NONE.
> >
> > Why?
> >
> > By unconditionally returning IRQ_HANDLED, this patch will surely break
> > systems where the UART IRQ is shared with other platforms.
> >
> > I just noticed this patch when bisecting a related problem.  Why
> > wasn't this Cc'd to linux-omap where OMAP users might have been more
> > likely to see it?
> >
> > Greg, without a better justification in the changelog, I think this
> > patch should be dropped from tty-next.
> 
> Can you drop this from tty-next please?
> 
> The authors aren't responding (one of the ti.com addresses bounced)
> and this "fix" is most is not correct.

Yes, sorry, behind on my pending tty patch queue.  I'll try to get to it
this week.

greg k-h

  reply	other threads:[~2013-08-27 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 13:29 [PATCH] serial: omap: Fix IRQ handling return value Alexander Savchenko
2013-07-17 13:29 ` Alexander Savchenko
2013-08-20 15:44 ` Kevin Hilman
2013-08-27 14:30   ` Kevin Hilman
2013-08-27 17:38     ` Greg KH [this message]
2013-08-27 23:04   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827173819.GD21564@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@ti.com \
    --cc=jslaby@suse.cz \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=oleksandr.savchenko@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.