From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] OMAP: UART: Keep the TX fifo full when possible Date: Tue, 27 Aug 2013 16:03:48 -0700 Message-ID: <20130827230348.GA5705@kroah.com> References: <1373277884-3006-1-git-send-email-oleksandr.savchenko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kevin Hilman Cc: Alexander Savchenko , jslaby@suse.cz, matts@commtech-fastcom.com, Paul McKenney , Santosh Shilimkar , dhowells@redhat.com, linux-serial@vger.kernel.org, LKML List-Id: linux-serial@vger.kernel.org On Tue, Aug 20, 2013 at 08:57:25AM -0700, Kevin Hilman wrote: > + Felipe > > On Mon, Jul 8, 2013 at 3:04 AM, Alexander Savchenko > wrote: > > From: Dmitry Fink > > > > Current logic results in interrupt storm since the fifo > > is constantly below the threshold level. Change the logic > > to fill all the available spaces in the fifo as long as > > we have data to minimize the possibilty of underflow and > > elimiate excessive interrupts. > > > > Signed-off-by: Dmitry Fink > > Signed-off-by: Alexander Savchenko > > Hmm, another OMAP serial patch that wasn't Cc'd to linux-omap where > OMAP users might have seen it. :( > > I just bisected a strange problem in linux-next on OMAP3 down to this > patch. Reverting it fixes the problem. > > On OMAP3530 Beagle and Overo, after boot, doing a 'cat /proc/cpuinfo' > was not returning to a prompt, suggesting something strange with the > FIFO. Hitting return gets me back to a prompt. > > Greg, this one should also be dropped from tty-next until it can be > further investgated and the problem solved. Now reverted, thanks. greg k-h