From: Greg KH <gregkh@linuxfoundation.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>
Cc: pavel@ucw.cz, justinmattock@gmail.com, harsh1kumar@gmail.com,
dan.carpenter@oracle.com, mujeeb.adil@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep
Date: Tue, 27 Aug 2013 16:38:32 -0700 [thread overview]
Message-ID: <20130827233832.GA25985@kroah.com> (raw)
In-Reply-To: <1377529823-5116-9-git-send-email-ikerpedrosam@gmail.com>
On Mon, Aug 26, 2013 at 05:10:07PM +0200, Iker Pedrosa wrote:
> According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead.
>
> Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
> ---
> drivers/staging/winbond/reg.c | 52 +++++++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
> index 80b4b34..61916f5 100644
> --- a/drivers/staging/winbond/reg.c
> +++ b/drivers/staging/winbond/reg.c
> @@ -890,9 +890,9 @@ void Uxx_power_on_procedure(struct hw_data *pHwData)
> else {
> Wb35Reg_WriteSync(pHwData, 0x03f4, 0xFF5807FF);
> Wb35Reg_WriteSync(pHwData, 0x03d4, 0x80); /* regulator on only */
> - msleep(10);
> + usleep(10000);
This breaks the build :(
next prev parent reply other threads:[~2013-08-27 23:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 15:09 [PATCH 00/24] Staging: winbond: Fixed some coding style issues Iker Pedrosa
2013-08-26 15:10 ` [PATCH 01/24] Staging: winbond: mto: removed function declaration Iker Pedrosa
2013-08-26 15:10 ` [PATCH 02/24] Staging: winbond: mto: avoided use of extern functions Iker Pedrosa
2013-08-26 15:10 ` [PATCH 03/24] Staging: winbond: mto: deleted " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 04/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 15:10 ` [PATCH 05/24] " Iker Pedrosa
2013-08-26 16:02 ` Dan Carpenter
2013-08-26 16:50 ` Joe Perches
2013-09-05 11:45 ` Pavel Machek
2013-08-27 23:46 ` Greg KH
2013-08-26 15:10 ` [PATCH 06/24] Staging: winbond: reg: erased trailing whitespace Iker Pedrosa
2013-08-26 15:10 ` [PATCH 07/24] Staging: winbond: reg: white space deleted Iker Pedrosa
2013-08-26 15:10 ` [PATCH 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-27 23:38 ` Greg KH [this message]
2013-08-26 15:10 ` [PATCH 09/24] Staging: winbond: reg: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 16:12 ` Dan Carpenter
2013-08-26 16:20 ` Dan Carpenter
2013-08-26 15:10 ` [PATCH 10/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 11/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 12/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 13/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 14/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 15/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 16/24] Staging: winbond: wb35reg_f: fixed " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation Iker Pedrosa
2013-08-26 15:10 ` [PATCH 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-26 15:10 ` [PATCH 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 15:10 ` [PATCH 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-27 23:38 ` Greg KH
2013-08-26 15:10 ` [PATCH 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err Iker Pedrosa
2013-08-26 15:10 ` [PATCH 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '[' Iker Pedrosa
2013-08-26 15:10 ` [PATCH 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 16:39 ` Dan Carpenter
2013-08-26 15:10 ` [PATCH 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-26 16:43 ` [PATCH 00/24] Staging: winbond: Fixed some coding style issues Dan Carpenter
2013-08-27 14:54 ` Iker Pedrosa
2013-08-30 11:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827233832.GA25985@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=harsh1kumar@gmail.com \
--cc=ikerpedrosam@gmail.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.