All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton@enomsg.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
	"'David Woodhouse'" <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 33/35] power: use dev_get_platdata()
Date: Tue, 27 Aug 2013 18:58:34 -0700	[thread overview]
Message-ID: <20130828015834.GH10506@lizard> (raw)
In-Reply-To: <20130813090039.GA5604@mwanda>

On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote:
> > > > Use the wrapper function for retrieving the platform data instead of
> > > > accessing dev->platform_data directly.
> > > 
> > > Um.. what is the benefit or rationale of this patch?
> > 
> > CC'ed Joe Perches, Dan Carpenter
> > 
> > Hi Anton Vorontsov,
> > 
> > Usually, using the wrapper function makes the code simpler.
> > Also, it make the code more readable.
> 
> Since people are asking my opinion, then yes using
> dev_get_platdata() as intended is better than open coding.  It's a
> coding standard thing.

I don't see any immediate benefit of applying this patch... It does not
fix anything now or in the near future (or we are about to add something
into dev_get_platdata() wrapper, or get rid of dev.platform_data member?
Any plans for this? Then it should be in the commit message.)

Without any plans to actually use the wrapper the patch is just a churn
[that might result into patch conflicts that I'll have to deal with], so
I'll refrain from applying it.

Thanks,

Anton

  reply	other threads:[~2013-08-28  2:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30  8:19 [PATCH 33/35] power: use dev_get_platdata() Jingoo Han
2013-08-09 22:04 ` Anton Vorontsov
2013-08-12  0:22   ` Jingoo Han
2013-08-13  9:00     ` Dan Carpenter
2013-08-28  1:58       ` Anton Vorontsov [this message]
2013-08-28  2:19         ` Jingoo Han
2013-08-28  8:36           ` Dan Carpenter
2013-08-29  0:25             ` Jingoo Han
2013-08-29  1:18             ` Anton Vorontsov
2013-08-29  2:07               ` 'Greg Kroah-Hartman'
2013-08-29  2:18                 ` Jingoo Han
2013-08-29  3:07                 ` Anton Vorontsov
2013-08-29 10:41                   ` Mark Brown
2013-08-29  2:14               ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130828015834.GH10506@lizard \
    --to=anton@enomsg.org \
    --cc=dan.carpenter@oracle.com \
    --cc=dwmw2@infradead.org \
    --cc=jg1.han@samsung.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.