All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH lnf-queue] api: add nfq_nlmsg_get_timestamp helper
Date: Wed, 28 Aug 2013 10:46:52 +0200	[thread overview]
Message-ID: <20130828084652.GJ32493@breakpoint.cc> (raw)
In-Reply-To: <20130826225325.GA4695@localhost>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Florian,
> 
> On Thu, Aug 22, 2013 at 05:07:17PM +0200, Florian Westphal wrote:
> > The NFQA_TIMESTAMP structure is in network byte order, so it seems
> > appropriate to add a helper to convert it to a timeval struct.
[..]

> I think we can update nfq_get_timestamp to use libmnl without breaking
> backward compatibility. Same thing with all other getter functions
> that we have.

How did you plan to do this without breaking api/abi?

To call the existing libnfnetlink based function given an libmnl attr[] array
you need to:

struct nfq_data d;
d.data = (void **) &attr[1];
nfq_get_timestamp(&d, &tv);

Which is just "ewww".

      reply	other threads:[~2013-08-28  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 15:07 [PATCH lnf-queue] api: add nfq_nlmsg_get_timestamp helper Florian Westphal
2013-08-26 22:53 ` Pablo Neira Ayuso
2013-08-28  8:46   ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130828084652.GJ32493@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.