From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices.
Date: Wed, 28 Aug 2013 10:44:34 +0200 [thread overview]
Message-ID: <201308281044.34429.marex@denx.de> (raw)
In-Reply-To: <1376995992-20870-3-git-send-email-p.marczak@samsung.com>
Dear Przemyslaw Marczak,
> This change allows using every mmc device instance with ums,
> like eMMC or SD cards.
>
> Example: ums <device_number> for mmc devices.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Marek Vasut <marek.vasut@gmail.com>
> ---
> common/cmd_usb_mass_storage.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c
> index 33a4715..4181d3a 100644
> --- a/common/cmd_usb_mass_storage.c
> +++ b/common/cmd_usb_mass_storage.c
> @@ -14,6 +14,7 @@
> int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
> int argc, char * const argv[])
> {
> + struct mmc *mmc = NULL;
> char *ep;
> unsigned int dev_num = 0, offset = 0, part_size = 0;
> int rc;
> @@ -28,8 +29,10 @@ int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
>
> dev_num = (int)simple_strtoul(argv[1], &ep, 16);
>
> - if (dev_num) {
> - puts("\nSet eMMC device to 0! - e.g. ums 0\n");
> + mmc = find_mmc_device(dev_num);
> +
> + if (!mmc) {
> + printf("\neMMC device: %d not found! Try ums 0.\n", dev_num);
> goto fail;
> }
You still use dev_num further in the code, why not convert the whole thing to
use *mmc ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-08-28 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 10:53 [U-Boot] [PATCH 1/3] arm:mmc:goni/exynos: Fix wrong mmc base register devices offset Przemyslaw Marczak
2013-08-20 10:53 ` [U-Boot] [PATCH 2/3] arm:goni:mmc: Add sd card detection and initialization Przemyslaw Marczak
2013-08-28 7:39 ` Przemyslaw Marczak
2013-08-28 8:41 ` Jaehoon Chung
2013-08-28 10:11 ` Przemyslaw Marczak
2013-08-28 14:36 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-08-29 3:11 ` Jaehoon Chung
2013-08-30 2:16 ` Minkyu Kang
2013-09-02 14:05 ` Przemyslaw Marczak
2013-08-20 10:53 ` [U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices Przemyslaw Marczak
2013-08-28 7:40 ` Przemyslaw Marczak
2013-08-28 8:44 ` Marek Vasut [this message]
2013-08-28 10:59 ` Przemyslaw Marczak
2013-08-28 11:03 ` Marek Vasut
2013-08-28 11:21 ` Przemyslaw Marczak
2013-08-28 11:25 ` Marek Vasut
2013-08-28 7:11 ` [U-Boot] [PATCH 1/3] arm:mmc:goni/exynos: Fix wrong mmc base register devices offset Przemyslaw Marczak
2013-08-28 8:45 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308281044.34429.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.