Re: [LTP] [PATCH] ltp: Fix races in mmap1

[chrubis@suse.cz]

Hi!
>  static int verbose_print = 0;
> -static char *map_address;
> +static char *volatile map_address;

Ok.

>  static jmp_buf jmpbuf;
>  static volatile char read_lock = 0;
>  
> @@ -228,11 +228,13 @@ void *read_mem(void *ptr)
>  				tst_resm(TINFO, "page fault occurred due to "
>  					 "a read after an unmap");
>  		} else {
> -			if (verbose_print)
> +			if (verbose_print) {
> +				read_lock = 1;
>  				tst_resm(TINFO,
>  					 "read_mem(): content of memory: %s",
>  					 (char *)map_address);
> -
> +				read_lock = 0;
> +			}
>  			for (j = 0; j < args[1]; j++) {
>  				read_lock = 1;
>  				if (map_address[j] != 'a')

Good catch, I've overlooked the tst_resm() when I was fixing the
testcase.

Commited, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list