From: Grant Likely <grant.likely@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <rob.herring@calxeda.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
Kumar Gala <galak@kernel.crashing.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH V6 5/5] gpio: implement gpio-ranges binding document fix
Date: Wed, 28 Aug 2013 21:47:43 +0100 [thread overview]
Message-ID: <20130828204743.4AF6E3E0B6B@localhost> (raw)
In-Reply-To: <1376515632-12594-5-git-send-email-swarren@wwwdotorg.org>
On Wed, 14 Aug 2013 15:27:12 -0600, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Use the new of_parse_phandle_with_fixed_args() to implement the
> corrected gpio-ranges DT property definition.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
I'll take this with the rest of the series.
g.
> ---
> drivers/gpio/gpiolib-of.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 665f953..48cda3c 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -194,8 +194,8 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)
> return;
>
> for (;; index++) {
> - ret = of_parse_phandle_with_args(np, "gpio-ranges",
> - "#gpio-range-cells", index, &pinspec);
> + ret = of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3,
> + index, &pinspec);
> if (ret)
> break;
>
> --
> 1.8.1.5
>
next prev parent reply other threads:[~2013-08-28 20:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 21:27 [PATCH V6 1/5] of: move documentation of of_parse_phandle_with_args Stephen Warren
2013-08-14 21:27 ` [PATCH V6 2/5] of: move of_parse_phandle() Stephen Warren
2013-08-28 19:30 ` Linus Walleij
2013-08-30 20:09 ` Stephen Warren
2013-08-31 0:32 ` Rob Herring
2013-08-28 20:43 ` Grant Likely
2013-08-14 21:27 ` [PATCH V6 3/5] of: introduce of_parse_phandle_with_fixed_args Stephen Warren
2013-08-28 20:44 ` Grant Likely
2013-08-14 21:27 ` [PATCH V6 4/5] of: call __of_parse_phandle_with_args from of_parse_phandle Stephen Warren
2013-08-14 21:27 ` [PATCH V6 5/5] gpio: implement gpio-ranges binding document fix Stephen Warren
2013-08-28 20:47 ` Grant Likely [this message]
2013-08-29 7:09 ` Linus Walleij
2013-08-21 17:47 ` [PATCH V6 1/5] of: move documentation of of_parse_phandle_with_args Stephen Warren
2013-08-28 20:42 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828204743.4AF6E3E0B6B@localhost \
--to=grant.likely@linaro.org \
--cc=Pawel.Moll@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=ian.campbell@citrix.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.