From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEzrJ-0001w4-HT for qemu-devel@nongnu.org; Thu, 29 Aug 2013 06:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEzrE-0002xP-Od for qemu-devel@nongnu.org; Thu, 29 Aug 2013 06:53:49 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:37962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEzrE-0002xC-HP for qemu-devel@nongnu.org; Thu, 29 Aug 2013 06:53:44 -0400 Date: Thu, 29 Aug 2013 12:53:38 +0200 From: Aurelien Jarno Message-ID: <20130829105337.GJ5908@ohm.aurel32.net> References: <1377190729-14008-1-git-send-email-rth@twiddle.net> <1377190729-14008-7-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1377190729-14008-7-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 06/18] tcg: Define TCG_ptr properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Thu, Aug 22, 2013 at 09:58:37AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tcg/tcg.h b/tcg/tcg.h > index b71dcf4..8353ba1 100644 > --- a/tcg/tcg.h > +++ b/tcg/tcg.h > @@ -640,11 +640,11 @@ do {\ > > void tcg_add_target_add_op_defs(const TCGTargetOpDef *tdefs); > > -#if TCG_TARGET_REG_BITS == 32 > +#if UINTPTR_MAX == UINT32_MAX > #define TCGV_NAT_TO_PTR(n) MAKE_TCGV_PTR(GET_TCGV_I32(n)) > #define TCGV_PTR_TO_NAT(n) MAKE_TCGV_I32(GET_TCGV_PTR(n)) > > -#define tcg_const_ptr(V) TCGV_NAT_TO_PTR(tcg_const_i32((tcg_target_long)(V))) > +#define tcg_const_ptr(V) TCGV_NAT_TO_PTR(tcg_const_i32((intptr_t)(V))) > #define tcg_global_reg_new_ptr(R, N) \ > TCGV_NAT_TO_PTR(tcg_global_reg_new_i32((R), (N))) > #define tcg_global_mem_new_ptr(R, O, N) \ > @@ -655,7 +655,7 @@ void tcg_add_target_add_op_defs(const TCGTargetOpDef *tdefs); > #define TCGV_NAT_TO_PTR(n) MAKE_TCGV_PTR(GET_TCGV_I64(n)) > #define TCGV_PTR_TO_NAT(n) MAKE_TCGV_I64(GET_TCGV_PTR(n)) > > -#define tcg_const_ptr(V) TCGV_NAT_TO_PTR(tcg_const_i64((tcg_target_long)(V))) > +#define tcg_const_ptr(V) TCGV_NAT_TO_PTR(tcg_const_i64((intptr_t)(V))) > #define tcg_global_reg_new_ptr(R, N) \ > TCGV_NAT_TO_PTR(tcg_global_reg_new_i64((R), (N))) > #define tcg_global_mem_new_ptr(R, O, N) \ > -- > 1.8.1.4 > > > Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net