From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VF5Tj-0000Vg-Ch
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 12:53:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VF5Te-0008W0-E5
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 12:53:51 -0400
Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:39551)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VF5Te-0008VB-6Z
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 12:53:46 -0400
Date: Thu, 29 Aug 2013 18:44:50 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130829164450.GC2287@ohm.aurel32.net>
References: <1377190729-14008-1-git-send-email-rth@twiddle.net>
	<1377190729-14008-15-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1377190729-14008-15-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 14/18] tcg: Fix jit debug for pointer size
 != register size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Thu, Aug 22, 2013 at 09:58:45AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/tcg.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index 72c064c..3c89e3b 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -49,10 +49,10 @@
>  
>  #include "tcg-op.h"
>  
> -#if TCG_TARGET_REG_BITS == 64
> -# define ELF_CLASS  ELFCLASS64
> -#else
> +#if UINTPTR_MAX == UINT32_MAX
>  # define ELF_CLASS  ELFCLASS32
> +#else
> +# define ELF_CLASS  ELFCLASS64
>  #endif
>  #ifdef HOST_WORDS_BIGENDIAN
>  # define ELF_DATA   ELFDATA2MSB
> @@ -82,8 +82,8 @@ typedef struct {
>  typedef struct QEMU_PACKED {
>      uint32_t len __attribute__((aligned((sizeof(void *)))));
>      uint32_t cie_offset;
> -    tcg_target_long func_start;
> -    tcg_target_long func_len;
> +    uintptr_t func_start;
> +    uintptr_t func_len;
>  } DebugFrameFDEHeader;
>  
>  static void tcg_register_jit_int(void *buf, size_t size,

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net