All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyle McMartin <kmcmarti@redhat.com>
To: Rob Herring <rob.herring@calxeda.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] xgmac: use bufsz not dma_buf_sz in rx_refill
Date: Thu, 29 Aug 2013 16:26:02 -0400	[thread overview]
Message-ID: <20130829202602.GK8764@redacted.bos.redhat.com> (raw)
In-Reply-To: <521FADFE.7040908@calxeda.com>

On Thu, Aug 29, 2013 at 03:24:30PM -0500, Rob Herring wrote:
> On 08/29/2013 03:11 PM, Kyle McMartin wrote:
> > Noticed while debugging another issue that DMA debug turned up, looks
> > like commit ef468d23 missed a case when switching to bufsz instead of
> > priv->dma_buf_sz? (tbf, the whole handling of DMA buffers seems slightly
> > suspect since we're not tracking the size, but trusting the hardware
> > between map and unmap...)
> 
> Please see my patch series of fixes:
> 
> http://www.spinics.net/lists/netdev/msg248076.html
> 

Hah, thanks. Yeah, I wondered wtf was up with get_buf_len, but figured
the hardware must have been doing something subtle. ;-)

I'll apply these to our Fedora tree and pass them along for testing.

Thanks Rob.

--Kyle

  reply	other threads:[~2013-08-29 20:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 20:11 [PATCH] xgmac: use bufsz not dma_buf_sz in rx_refill Kyle McMartin
2013-08-29 20:24 ` Rob Herring
2013-08-29 20:26   ` Kyle McMartin [this message]
2013-08-29 20:38   ` David Miller
2013-08-29 20:31 ` Sergei Shtylyov
2013-08-29 20:34 ` David Miller
2013-08-29 20:35   ` Kyle McMartin
2013-08-29 20:38     ` David Miller
2013-08-30  3:17       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130829202602.GK8764@redacted.bos.redhat.com \
    --to=kmcmarti@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.