From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: [Question]: about the paramters of func generic_file_buffered_write. Date: Fri, 30 Aug 2013 17:14:47 +0800 Message-ID: <201308301714452181275@gmail.com> Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: base64 Cc: linux-fsdevel , LKML To: viro Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org SGkgYWxsLA0KCVRoZSBkZWZpbml0aW9uIG9mIGZ1bmMgZ2VuZXJpY19maWxlX2J1ZmZlcmVkX3dy aXRlIGlzOg0KIAkJc3NpemVfdCBnZW5lcmljX2ZpbGVfYnVmZmVyZWRfd3JpdGUoc3RydWN0IGtp b2NiICosIGNvbnN0IHN0cnVjdCBpb3ZlYyAqLA0KICAgICAgICAgICAgICAgIAkJCQkJCQl1bnNp Z25lZCBsb25nLCBsb2ZmX3QsIGxvZmZfdCAqLCBzaXplX3QsIHNzaXplX3QpOw0KVGhlIGZvdXJ0 aCBhbmQgZmlmdGggcGFyYXRtZXJzIGluZGljYXRlIHRoZSBjdXJyZW50IHBvcyBvZiBmaWxlLg0K RXZlcnkgcGxhY2Ugd2hpY2ggY2FsbCB0aGlzIGZ1bmN0aW9uLCBpdCBzZXQgdGhlIGZvdXJ0aCB0 byBpb2NiLT5raV9wb3MobWF5YmUgbm90IGJ1dCBlcXVhbCkuDQpUaGUgZmlmdGggcGFyYW1ldGVy IGlzIHNldCAmaW9jYi0+a2lfcG9zLg0KDQpJIHRoaW5rIHdlIGNhbiByZW1vdmUgdHdvIHBhcmFt ZXRlcnMuIFRob3NlIHBhcmFtZXRlciBjYW4gcmVwbGFjZSBieSB0aGUgZmlsZXMgb2Ygc3RydWN0 IGtpb2NiIGluIHRoZSBmdW4NCm9mIGdlbmVyaWNfZmlsZV9idWZmZXJlZF93cml0ZS4NCg0KT3Ig YW0gaSBtaXNzaW5nIHNvbWV0aGluZz8NCg0KVGhhbnNrIQ0KSmlhbnBlbmcgTWE= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755034Ab3H3JO6 (ORCPT ); Fri, 30 Aug 2013 05:14:58 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:49682 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754755Ab3H3JOz (ORCPT ); Fri, 30 Aug 2013 05:14:55 -0400 Date: Fri, 30 Aug 2013 17:14:47 +0800 From: majianpeng To: viro Cc: linux-fsdevel , LKML Reply-To: majianpeng Subject: [Question]: about the paramters of func generic_file_buffered_write. X-Priority: 3 X-GUID: 98E6E0C5-5C46-4119-81BC-346F11BF7093 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.93[cn] Mime-Version: 1.0 Message-ID: <201308301714452181275@gmail.com> Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r7U9F39k022640 Hi all, The definition of func generic_file_buffered_write is: ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *, unsigned long, loff_t, loff_t *, size_t, ssize_t); The fourth and fifth paratmers indicate the current pos of file. Every place which call this function, it set the fourth to iocb->ki_pos(maybe not but equal). The fifth parameter is set &iocb->ki_pos. I think we can remove two parameters. Those parameter can replace by the files of struct kiocb in the fun of generic_file_buffered_write. Or am i missing something? Thansk! Jianpeng Ma{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I