All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix bad dquot buffer size in log recovery readahead
Date: Fri, 30 Aug 2013 13:38:51 -0500	[thread overview]
Message-ID: <20130830183851.GF1935@sgi.com> (raw)
In-Reply-To: <20130827214534.GZ5262@sgi.com>

On Tue, Aug 27, 2013 at 04:45:34PM -0500, Ben Myers wrote:
> On Tue, Aug 27, 2013 at 01:25:43PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> > 
> > xfstests xfs/087 fails 100% reliably with this assert:
> > 
> > XFS (vdb): Mounting Filesystem
> > XFS (vdb): Starting recovery (logdev: internal)
> > XFS: Assertion failed: bp->b_flags & XBF_STALE, file: fs/xfs/xfs_buf.c, line: 548
> > 
> > while trying to read a dquot buffer in xlog_recover_dquot_ra_pass2().
> > 
> > The issue is that the buffer length to read that is passed to
> > xfs_buf_readahead is in units of filesystem blocks, not disk blocks.
> > (i.e. FSB, not daddr). Fix it but putting the correct conversion in
> > place.
> > 
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> 
> Looks good.
> 
> Reviewed-by: Ben Myers <bpm@sgi.com>

Also applied this one...

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-08-30 18:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  3:25 [PATCH] xfs: fix bad dquot buffer size in log recovery readahead Dave Chinner
2013-08-27 21:45 ` Ben Myers
2013-08-30 18:38   ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830183851.GF1935@sgi.com \
    --to=bpm@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.