All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <esandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
Date: Fri, 30 Aug 2013 15:21:06 -0500	[thread overview]
Message-ID: <20130830202106.GK1935@sgi.com> (raw)
In-Reply-To: <44DD3D7C-C7C8-483C-BA6D-DFF31E6363ED@redhat.com>

On Fri, Aug 23, 2013 at 04:17:07PM -0400, Eric Sandeen wrote:
> On Aug 23, 2013, at 3:11 PM, Ben Myers <bpm@sgi.com> wrote:
> 
> > Hey Eric,
> > 
> > On Fri, Mar 30, 2012 at 11:24:11AM -0500, Eric Sandeen wrote:
> >> This ASSERT is testing an if_flags flag value against
> >> a di_aformat enum value.  di_aformat is never assigned
> >> XFS_IFINLINE.
> >> 
> >> This happens to work for now, because XFS_IFINLINE has
> >> the same value as XFS_DINODE_FMT_LOCAL, and that's tested
> >> just before we call this function.
> >> 
> >> However, I think the intention is to assert that we have
> >> read in the data, i.e. XFS_IFINLINE on if_flags, before
> >> we use if_data.  This is done in other places through the
> >> code as well.
> >> 
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > 
> > Looks like this one fell through the cracks.  You still interested in merging
> > it?
> > 
> Yep - it's fallen out of my brain by mow but if it was correct then I think it's correct now...

Applied.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-08-30 20:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 16:24 [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue Eric Sandeen
2012-03-31 15:39 ` Christoph Hellwig
2013-08-23 20:11 ` Ben Myers
2013-08-23 20:17   ` Eric Sandeen
2013-08-30 20:21     ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830202106.GK1935@sgi.com \
    --to=bpm@sgi.com \
    --cc=esandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.