Re: --minimal does not work in client/server mode

[Jens Axboe <axboe@kernel.dk>]

On Thu, Aug 29 2013, asomers@gmail.com wrote:
> On Mon, Jul 29, 2013 at 10:23 AM, Jens Axboe <axboe@kernel.dk> wrote:
> >
> > On 07/29/2013 10:00 AM, asomers@gmail.com wrote:
> > > I found a few more things that need to be suppressed in terse mode.
> > > The updated patch is here.  In addition to working with JSON output,
> > > we also need to check that the patch doesn't break disk statistics.  I
> > > haven't tried using those at all yet.
> > >
> > > https://gist.github.com/asomers/6105396
> >
> > I would suggest making a show_thread_status_all() that does something ala:
> >
> > void show_thread_status_all()
> > {
> >    if (is_backend)
> >        fio_server_send_ts(ts, rs);
> >    else if (output_format == FIO_OUTPUT_TERSE)
> >        show_thread_status_terse(ts, rs);
> >    else if (output_format == FIO_OUTPUT_JSON) {
> >        struct json_object *tmp = show_thread_status_json(ts, rs);
> >
> >        json_array_add_value_object(array, tmp);
> >    } else
> >        show_thread_status(ts, rs);
> > }
> >
> > which should work for all. If you could check and fix the json bit too,
> > bonus points, and I'll test and commit it. Thanks!
> >
> >
> > --
> > Jens Axboe
> >
> 
> Try this new set of patches.  They get json output working in client/server
> mode. This is my third attempt to send them; your server keeps rejecting
> gmail's HTML.  Sorry for the overposts.
> 
> https://gist.github.com/asomers/6105396

Thanks! I'll take a look at this soon and hopefully get it added.

-- 
Jens Axboe