From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: android: Mark local functions in binder.c as static
Date: Sun, 01 Sep 2013 23:10:31 +0000 [thread overview]
Message-ID: <20130901231030.GX6329@mwanda> (raw)
In-Reply-To: <1378066724-6340-1-git-send-email-prtvar.b@gmail.com>
On Sun, Sep 01, 2013 at 10:18:44PM +0200, Bojan Prtvar wrote:
> -void binder_stat_br(struct binder_proc *proc, struct binder_thread *thread,
> +static void binder_stat_br(struct binder_proc *proc,
> + struct binder_thread *thread,
> uint32_t cmd)
The indenting needs to be updated to match as well. Add 3 spaces before
"struct binder_thread" and move the "uint32_t cmd)" up a line. Like
this:
static void binder_stat_br(struct binder_proc *proc,
struct binder_thread *thread, uint32_t cmd)
{
regards,
dan carpenter
prev parent reply other threads:[~2013-09-01 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 20:18 [PATCH] Staging: android: Mark local functions in binder.c as static Bojan Prtvar
2013-09-01 23:10 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130901231030.GX6329@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.