From: Josh Triplett <josh@joshtriplett.org>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org,
sparse@chrisli.org, lttng-dev@lists.lttng.org,
Stephen Hemminger <stephen@networkplumber.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Subject: Re: rcu: Make rcu_assign_pointer's assignment volatile and type-safe
Date: Sun, 1 Sep 2013 17:06:26 -0700 [thread overview]
Message-ID: <20130902000626.GA22111@leaf> (raw)
In-Reply-To: <5223d2b1.W0Uf1KjUIaBOcCMH%wangshilong1991@gmail.com>
On Mon, Sep 02, 2013 at 07:50:09AM +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: line over 80 characters
> #57: FILE: include/linux/rcupdate.h:518:
> + extern void __rcu_assign_pointer_typecheck(int, typeof(*(v)) __kernel *); \
It'd get much uglier if wrapped, and the function name needs to stay
unique to avoid conflicts with the macro context. I don't plan to
change this.
> ERROR: need consistent spacing around '*' (ctx:WxB)
> #72: FILE: include/linux/rcupdate.h:568:
> + ACCESS_ONCE(p) = (typeof(*(v)) __force space *)(v); \
False positive; checkpatch.pl seems to parse this as multiplication
rather than a cast.
- Josh Triplett
next prev parent reply other threads:[~2013-09-02 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 23:50 rcu: Make rcu_assign_pointer's assignment volatile and type-safe Wang Shilong
2013-09-02 0:06 ` Josh Triplett [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-01 23:50 Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902000626.GA22111@leaf \
--to=josh@joshtriplett.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sparse@chrisli.org \
--cc=stephen@networkplumber.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.