From: "Jon Arne Jørgensen" <jonarne@jonarne.no>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: "Jon Arne Jørgensen" <jonarne@jonarne.no>,
linux-kernel@vger.kernel.org, lkundrak@v3.sk,
mkrufky@linuxtv.org, hans.verkuil@cisco.com,
rdunlap@infradead.org
Subject: Re: [RFC,v3] Add a driver for the Somagic smi2021 chip
Date: Mon, 2 Sep 2013 08:56:37 +0200 [thread overview]
Message-ID: <20130902065637.GA22726@server.arpanet.local> (raw)
In-Reply-To: <52239a76.XU34CEethg4oyQtW%wangshilong1991@gmail.com>
On Mon, Sep 02, 2013 at 03:50:14AM +0800, Wang Shilong wrote:
Hi,
> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: Avoid CamelCase: <udev->descriptor.idProduct>
> #1766: FILE: drivers/media/usb/smi2021/smi2021_main.c:790:
> + if (udev->descriptor.idProduct == BOOTLOADER_ID)
>
> total: 0 errors, 1 warnings, 2110 lines checked
>
> patch has style problems, please review.
>
That problem lies within the usb-subsystem.
When I ran checkpatch.pl on the patch before submitting this didn't show up.
Are you using an old version of checkpatch.pl?
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Thanks, Wang
>
> Notice: this is an automatically generated by shell script
> Any problems please contact: wangshilong1991@gmail.com
next parent reply other threads:[~2013-09-02 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52239a76.XU34CEethg4oyQtW%wangshilong1991@gmail.com>
2013-09-02 6:56 ` Jon Arne Jørgensen [this message]
2013-09-01 19:42 [RFC v3] Add a driver for the somagic smi2021 chip Jon Arne Jørgensen
2013-09-01 19:42 ` [RFC v3] Add a driver for the Somagic " Jon Arne Jørgensen
2013-10-03 15:16 ` Mauro Carvalho Chehab
2013-10-04 9:14 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902065637.GA22726@server.arpanet.local \
--to=jonarne@jonarne.no \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mkrufky@linuxtv.org \
--cc=rdunlap@infradead.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.