Re: [PATCHv5 0/9] New EH command timeout handler

[Christoph Hellwig <hch@infradead.org>]

On Mon, Sep 02, 2013 at 10:54:13AM +0200, Hannes Reinecke wrote:
> I don't mind. Having talked to the various SCSI folks everyone
> agreed that calling abort asynchronously shouldn't do any harm.
> At least as far as the SCSI spec goes.
> 
> As for documentation: I didn't document it it currently as with my
> implementation it's pretty much an optional thing.
> But if we were to enable it globally it surely should be documented.
> 
> So if there is a consensus I surely can enable it globally and
> update the documentation.

I would defintively love enabling it globally.  As a fallback we should
probably keep the old code for a while and prepare a way to disable
the async code by a flag in the host template.  If no reason to enable
it shows up after a year ore two we can remove the old code entirely.

I.e change the tail of scsi_times_out into something like:


	if (rtn == BLK_EH_NOT_HANDLED && !shost->hostt->no_async_abort) {
		if (scsi_abort_command(scmd))
			return BLK_EH_NOT_HANDLED;
	}

	scmd->result |= DID_TIME_OUT << 16;
	...

That way we don't even need the new BLK_EH_SCHEDULED return value and
have all the handling in scsi_error.c