From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: fix some minor sparse warnings
Date: Mon, 2 Sep 2013 20:09:57 +1000 [thread overview]
Message-ID: <20130902100957.GE12779@dastard> (raw)
In-Reply-To: <20130902081954.GD11210@infradead.org>
On Mon, Sep 02, 2013 at 01:19:54AM -0700, Christoph Hellwig wrote:
> > --- a/fs/xfs/xfs_dquot_item.c
> > +++ b/fs/xfs/xfs_dquot_item.c
> > @@ -143,6 +143,8 @@ STATIC uint
> > xfs_qm_dquot_logitem_push(
> > struct xfs_log_item *lip,
> > struct list_head *buffer_list)
> > + __releases(&lip->li_ailp->xa_lock)
> > + __acquires(&lip->li_ailp->xa_lock)
> > {
>
> Having these markers indented the same amount as the parameters isn't
> very readable. Maybe give them another tab level?
Sure. Can do.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-02 10:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 3:22 [PATCH 0/2] xfs: fix some sparse warnings Dave Chinner
2013-09-02 3:22 ` [PATCH 1/2] xfs: fix endian warning in xlog_recover_get_buf_lsn() Dave Chinner
2013-09-02 8:18 ` Christoph Hellwig
2013-09-09 22:50 ` Ben Myers
2013-09-02 3:22 ` [PATCH 2/2] xfs: fix some minor sparse warnings Dave Chinner
2013-09-02 8:19 ` Christoph Hellwig
2013-09-02 10:09 ` Dave Chinner [this message]
2013-09-02 10:49 ` [PATCH 2/2 v2] " Dave Chinner
2013-09-09 22:50 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902100957.GE12779@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.