All of lore.kernel.org
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] RFC add _FORTIFY_SOURCE to default LTP CFLAGS
Date: Mon, 2 Sep 2013 16:27:54 +0200	[thread overview]
Message-ID: <20130902142754.GA26252@rei> (raw)
In-Reply-To: <20130902122315.GC3269@rei>

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

Hi!
> > you could probably turn that AH_VERBATIM into a compile test and then add it 
> > to CPPFLAGS based on the result.  that would probably work in most cases.
> 
> So back to the beginning...

What about this patch?
(it's tested and works)

-- 
Cyril Hrubis
chrubis@suse.cz

[-- Attachment #2: 0001-configure-Add-_FORTIFY_SOURCE-2.patch --]
[-- Type: text/x-diff, Size: 2305 bytes --]

From 9d69dc34b6f08e742d79a30b4253371836de7367 Mon Sep 17 00:00:00 2001
From: Cyril Hrubis <chrubis@suse.cz>
Date: Mon, 2 Sep 2013 16:13:16 +0200
Subject: [PATCH] configure: Add _FORTIFY_SOURCE=2

Add -D_FORTIFY_SOURCE=2 into CPPFLAGS if:

o it's not allready set in system headers
o optimalization is enabled

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 configure.ac             |  2 +-
 m4/ltp-fortify_source.m4 | 39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 m4/ltp-fortify_source.m4

diff --git a/configure.ac b/configure.ac
index f0fc6b0..81f92ab 100644
--- a/configure.ac
+++ b/configure.ac
@@ -144,7 +144,7 @@ else
 fi
 
 # END testsuites knobs
-
+LTP_CHECK_FORTIFY_SOURCE
 LTP_CHECK_MKDTEMP
 LTP_CHECK_CAPABILITY_SUPPORT
 LTP_CHECK_CRYPTO
diff --git a/m4/ltp-fortify_source.m4 b/m4/ltp-fortify_source.m4
new file mode 100644
index 0000000..ffb22b4
--- /dev/null
+++ b/m4/ltp-fortify_source.m4
@@ -0,0 +1,39 @@
+dnl
+dnl Copyright (c) 2013 Cyril Hrubis <chrubis@suse.cz>
+dnl
+dnl This program is free software;  you can redistribute it and/or modify
+dnl it under the terms of the GNU General Public License as published by
+dnl the Free Software Foundation; either version 2 of the License, or
+dnl (at your option) any later version.
+dnl
+dnl This program is distributed in the hope that it will be useful,
+dnl but WITHOUT ANY WARRANTY;  without even the implied warranty of
+dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
+dnl the GNU General Public License for more details.
+dnl
+dnl You should have received a copy of the GNU General Public License
+dnl along with this program;  if not, write to the Free Software
+dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+dnl
+
+dnl
+dnl LTP_CHECK_FORTIFY_SOURCE
+dnl ------------------------
+dnl
+AC_DEFUN([LTP_CHECK_FORTIFY_SOURCE],[dnl
+	AC_MSG_CHECKING(whether to define _FORTIFY_SOURCE=2)
+	AC_COMPILE_IFELSE([AC_LANG_SOURCE([
+#include <stdio.h>
+
+int main(void)
+{
+#if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__
+	return 0;
+#else
+# error Compiling without optimalizations
+#endif
+}
+])],[CPPFLAGS="$CPPFLAGS -D_FORTIFY_SOURCE=2"
+AC_MSG_RESULT(yes)],
+[AC_MSG_RESULT(no)])
+])
-- 
1.8.1.5


[-- Attachment #3: Type: text/plain, Size: 433 bytes --]

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2013-09-02 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 11:00 [LTP] RFC add _FORTIFY_SOURCE to default LTP CFLAGS chrubis
     [not found] ` <201308242143.45598.vapier@gentoo.org>
2013-08-27 11:04   ` chrubis
     [not found]     ` <201308271218.22009.vapier@gentoo.org>
2013-08-28 11:56       ` chrubis
     [not found]         ` <201308281234.41447.vapier@gentoo.org>
2013-08-28 16:37           ` Mike Frysinger
2013-09-02 12:23             ` chrubis
2013-09-02 14:27               ` chrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130902142754.GA26252@rei \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.