From: Josh Triplett <josh@joshtriplett.org>
To: Joe Perches <joe@perches.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
ksummit-2013-discuss@lists.linuxfoundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH] checkpatch: Report missing spaces around trigraphs with --strict
Date: Mon, 2 Sep 2013 17:32:15 -0700 [thread overview]
Message-ID: <20130903003215.GA1614@leaf> (raw)
In-Reply-To: <1378166065.1953.134.camel@joe-AO722>
On Mon, Sep 02, 2013 at 04:54:25PM -0700, Joe Perches wrote:
> > would you mind looking at why
> > it gives a false positive for spaces around '*' on my recent patch at
> > http://mid.gmane.org/20130901234251.GB25057@leaf ? It appears to
> > mistake the '*' of a pointer for a multiply.
>
> Looks like checkpatch thinks this should be a multiplication.
>
> Try this:
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9bb056c..e421b5e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3005,7 +3005,7 @@ sub process {
> $op eq '*' or $op eq '/' or
> $op eq '%')
> {
> - if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
> + if ($ctx =~ /Wx[^WCEB]|[^WCE]xW/) {
> if (ERROR("SPACING",
> "need consistent spacing around '$op' $at\n" . $hereptr)) {
> $good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
>
>
That patch does indeed fix the problem, thanks!
Tested-by: Josh Triplett <josh@joshtriplett.org>
next prev parent reply other threads:[~2013-09-03 0:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9976.1378132260@warthog.procyon.org.uk>
2013-09-02 16:10 ` Making changes to the Coding Style Joe Perches
2013-09-02 18:15 ` [Ksummit-2013-discuss] " Josh Triplett
2013-09-02 18:19 ` [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle Josh Triplett
2013-09-02 18:39 ` [Ksummit-2013-discuss] " Mauro Carvalho Chehab
2013-09-02 18:59 ` Joe Perches
2013-09-02 19:48 ` Mauro Carvalho Chehab
2013-09-02 19:50 ` Josh Triplett
2013-09-02 20:04 ` Guenter Roeck
2013-09-02 22:14 ` [PATCH] checkpatch: Report missing spaces around trigraphs with --strict Joe Perches
2013-09-02 23:15 ` Josh Triplett
2013-09-02 23:54 ` Joe Perches
2013-09-03 0:32 ` Josh Triplett [this message]
2013-09-02 20:50 ` [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle David Howells
2013-09-02 21:11 ` Joe Perches
2013-09-03 0:26 ` Shilong Wang
2013-09-03 0:36 ` Josh Triplett
2013-09-03 1:21 ` Fengguang Wu
2013-09-03 0:39 ` Fengguang Wu
2013-09-03 0:47 ` Joe Perches
2013-09-03 1:35 ` Fengguang Wu
2013-09-03 1:34 ` Josh Triplett
2013-09-03 1:52 ` Joe Perches
2013-09-03 2:12 ` Josh Triplett
2013-09-03 2:21 ` Joe Perches
2013-09-03 2:46 ` Fengguang Wu
2013-09-03 3:16 ` Josh Triplett
2013-09-03 3:22 ` Fengguang Wu
2013-09-03 18:09 ` Bjorn Helgaas
2013-09-04 0:49 ` Fengguang Wu
2013-09-02 22:08 ` Josh Triplett
2013-09-02 19:34 ` Josh Triplett
2013-09-02 19:40 ` [PATCH] checkpatch: Add warning about submitting patches using --file Joe Perches
2013-09-02 19:54 ` [Ksummit-2013-discuss] " Mauro Carvalho Chehab
2013-09-02 19:56 ` Josh Triplett
2013-09-02 20:37 ` Dan Carpenter
2013-09-02 21:51 ` Joe Perches
2013-09-17 21:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903003215.GA1614@leaf \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=ksummit-2013-discuss@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.chehab@samsung.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.