From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfstests: Obey mkfs options for sized filesystems on XFS
Date: Tue, 3 Sep 2013 00:34:50 -0700 [thread overview]
Message-ID: <20130903073450.GC1422@infradead.org> (raw)
In-Reply-To: <1378167295-7566-3-git-send-email-david@fromorbit.com>
On Tue, Sep 03, 2013 at 10:14:54AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The XFS implementation of _scratch_mkfs_sized ignores MKFS_OPTIONS
> when a custom block size is set and so isn't testing things like
> CRCs on such sized filesytsems. Fix this by ensuring we don't try to
> override the block size is it is set in MKFS_OPTIONS. xfs/204 shows
> this problem.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good.
Maybe someone more familar with the other mkfs tools should cross-check
those as well.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-03 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 0:14 [PATCH 0/3] xfstests: improvements for generic/204 Dave Chinner
2013-09-03 0:14 ` [PATCH 1/3] xfstests: generic/204 should call _check_scratch_fs Dave Chinner
2013-09-03 7:33 ` Christoph Hellwig
2013-09-03 0:14 ` [PATCH 2/3] xfstests: Obey mkfs options for sized filesystems on XFS Dave Chinner
2013-09-03 7:34 ` Christoph Hellwig [this message]
2013-09-03 0:14 ` [PATCH 3/3] xfstests: Make 204 work with different block and inode sizes Dave Chinner
2013-10-14 13:10 ` Rich Johnston
2013-10-14 13:09 ` [PATCH 0/3] xfstests: improvements for generic/204 Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903073450.GC1422@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.