From: Stephen Hemminger <stephen@networkplumber.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: [iproute2 PATCH] iproute2: linklayer interface between kernel and tc/userspace
Date: Tue, 3 Sep 2013 08:33:15 -0700 [thread overview]
Message-ID: <20130903083315.1639bb0f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130830120210.1510.80733.stgit@localhost>
On Fri, 30 Aug 2013 14:02:10 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> This iproute2 tc patch is connected to the kernel
> - commit 8a8e3d84b17 (net_sched: restore "linklayer atm" handling)
>
> The rate table calculated by tc, have gotten replaced in the kernel
> and is no-longer used for lookups.
>
> This happened in kernel release v3.8 caused by kernel
> - commit 56b765b79 ("htb: improved accuracy at high rates").
> This change unfortunately caused breakage of tc overhead and
> linklayer parameters.
>
> Kernel overhead handling got fixed in kernel v3.10 by
> - commit 01cb71d2d47 (net_sched: restore "overhead xxx" handling)
>
> Kernel linklayer handling got fixed in kernel v3.11 by
> - commit 8a8e3d84b17 (net_sched: restore "linklayer atm" handling)
>
> The linklayer fix introduced a struct change, that allow the linklayer
> attribute to be transferred between tc and kernel. This patch make use
> of this linklayer attribute.
>
> The linklayer setting is transfer to the kernel. And linklayer
> setting received from the kernel is printed with a prefixed
> "linklayer" when listing current configuration. The default
> TC_LINKLAYER_ETHERNET is only printed in detailed output mode.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Ok, Applied for 3.11
prev parent reply other threads:[~2013-09-03 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 12:02 [iproute2 PATCH] iproute2: linklayer interface between kernel and tc/userspace Jesper Dangaard Brouer
2013-09-03 15:33 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903083315.1639bb0f@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=brouer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.