All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: iser-target: introduce fast memory registration mode (FRWR)
Date: Tue, 3 Sep 2013 14:14:36 +0300	[thread overview]
Message-ID: <20130903111436.GA15230@elgon.mountain> (raw)

Hello Vu Pham,

This is a semi-automatic email about new static checker warnings.

The patch 12050ce23475: "iser-target: introduce fast memory 
registration mode (FRWR)" from Aug 28, 2013, leads to the following 
Smatch complaint:

drivers/infiniband/ulp/isert/ib_isert.c:622 isert_connect_release()
	 warn: variable dereferenced before check 'device' (see line 598)

drivers/infiniband/ulp/isert/ib_isert.c
   597		if (device->use_frwr)
                    ^^^^^^^^^^^^^^^^
Patch introduces dereference.

   598			isert_conn_free_frwr_pool(isert_conn);
   599	

[ snip ]

   620		kfree(isert_conn);
   621	
   622		if (device)
                    ^^^^^^
Existing check.

   623			isert_device_try_release(device);
   624	

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2013-09-03 11:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 11:14 Dan Carpenter [this message]
     [not found] ` <20130903111436.GA15230-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-10-19  8:29   ` iser-target: introduce fast memory registration mode (FRWR) Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903111436.GA15230@elgon.mountain \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.