From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 03 Sep 2013 15:38:48 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:58719 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6824771Ab3ICNimzdmoY (ORCPT ); Tue, 3 Sep 2013 15:38:42 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.5/8.14.4) with ESMTP id r83DceXZ010664; Tue, 3 Sep 2013 15:38:40 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.5/8.14.5/Submit) id r83DcdXH010627; Tue, 3 Sep 2013 15:38:39 +0200 Date: Tue, 3 Sep 2013 15:38:39 +0200 From: Ralf Baechle To: Markos Chandras Cc: linux-mips@linux-mips.org Subject: Re: [PATCH v2] MIPS: ath79: Avoid using unitialized 'reg' variable Message-ID: <20130903133839.GA10563@linux-mips.org> References: <1377082042-4219-1-git-send-email-markos.chandras@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377082042-4219-1-git-send-email-markos.chandras@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37743 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Aug 21, 2013 at 11:47:22AM +0100, Markos Chandras wrote: > Fixes the following build error: > arch/mips/include/asm/mach-ath79/ath79.h:139:20: error: 'reg' may be used > uninitialized in this function [-Werror=maybe-uninitialized] > arch/mips/ath79/common.c:62:6: note: 'reg' was declared here > In file included from arch/mips/ath79/common.c:20:0: > arch/mips/ath79/common.c: In function 'ath79_device_reset_clear': > arch/mips/include/asm/mach-ath79/ath79.h:139:20: > error: 'reg' may be used uninitialized in this function > [-Werror=maybe-uninitialized] > arch/mips/ath79/common.c:90:6: note: 'reg' was declared here > > Signed-off-by: Markos Chandras > --- > Changes since v1: > http://www.linux-mips.org/archives/linux-mips/2013-08/msg00126.html > - Remove BUG(). panic() is enough. > http://www.linux-mips.org/archives/linux-mips/2013-08/msg00133.html > - Change panic() message to be more accurate. > http://www.linux-mips.org/archives/linux-mips/2013-08/msg00164.html > --- > arch/mips/ath79/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/ath79/common.c b/arch/mips/ath79/common.c > index eb3966c..6d7a9d4 100644 > --- a/arch/mips/ath79/common.c > +++ b/arch/mips/ath79/common.c > @@ -75,7 +75,7 @@ void ath79_device_reset_set(u32 mask) > else if (soc_is_qca955x()) > reg = QCA955X_RESET_REG_RESET_MODULE; > else > - BUG(); > + panic("Reset register not defined for this SOC"); > > spin_lock_irqsave(&ath79_device_reset_lock, flags); > t = ath79_reset_rr(reg); > @@ -103,7 +103,7 @@ void ath79_device_reset_clear(u32 mask) > else if (soc_is_qca955x()) > reg = QCA955X_RESET_REG_RESET_MODULE; > else > - BUG(); > + panic("Reset register not defined for this SOC"); > > spin_lock_irqsave(&ath79_device_reset_lock, flags); > t = ath79_reset_rr(reg); Looks more like the implementation of BUG() is wrong and gcc doesn't notice that BUG() won't return. Was this triggered by CONFIG_BUG=n? Ralf