From: Andrew Morton <akpm@linux-foundation.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Asias He <asias@redhat.com>, Kent Overstreet <kmo@daterainc.com>,
Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <andi@firstfloor.org>,
Christoph Lameter <cl@gentwo.org>,
Oleg Nesterov <oleg@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH-v5 1/6] idr: Percpu ida
Date: Tue, 3 Sep 2013 18:27:49 -0700 [thread overview]
Message-ID: <20130903182749.21052ab6.akpm@linux-foundation.org> (raw)
In-Reply-To: <1378224418.32763.409.camel@haakon3.risingtidesystems.com>
On Tue, 03 Sep 2013 09:06:58 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> Are there any other review comments to be addressed for this patch..?
>
> If not, please kindly give your Reviewed-by if your OK for an initial
> standalone merge.
Sorry, I'm largely offline for the next week...
It looks OK to me (that's as close as I get to an ack :))
Nit:
> + if (cpu >= nr_cpu_ids)
> + cpu = cpumask_first(&pool->cpus_have_tags);
> +
> + if (cpu >= nr_cpu_ids)
> + BUG();
The second `if' can be moved inside the first, but hopefully the
compiler already did that.
I have dim memories that doing
local_irq_save()
spin_lock()
is not equivalent to
spin_lock_irqsave()
in some circumstances. Perhaps a lockdep thing. Or perhaps this was fixed in
the intervening years and this is no longer the case.
Such things probably won't be detected during 3.12-rcX because few
people will test iscsi, I expect. So please be sure that you've
runtime tested it with all the lockdeppy things enabled.
Documentation/SubmitChecklist section 12 has a list, but it might be
dated.
next prev parent reply other threads:[~2013-09-04 1:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 2:52 [PATCH-v5 0/6] target/vhost/iscsi: Add per-cpu ida tag pre-allocation for v3.12 Nicholas A. Bellinger
2013-08-31 2:52 ` [PATCH-v5 1/6] idr: Percpu ida Nicholas A. Bellinger
2013-09-03 16:06 ` Nicholas A. Bellinger
2013-09-04 1:27 ` Andrew Morton [this message]
2013-09-04 4:42 ` Nicholas A. Bellinger
2013-08-31 2:52 ` [PATCH-v5 2/6] target: Add transport_init_session_tags using per-cpu ida Nicholas A. Bellinger
2013-09-03 8:16 ` Asias He
2013-08-31 2:52 ` [PATCH-v5 3/6] vhost/scsi: Convert to per-cpu ida_alloc + ida_free command map Nicholas A. Bellinger
2013-08-31 2:52 ` [PATCH-v5 4/6] vhost/scsi: Add pre-allocation for tv_cmd SGL + upages memory Nicholas A. Bellinger
2013-09-03 8:13 ` Asias He
2013-08-31 2:52 ` [PATCH-v5 5/6] iscsi/iser-target: Convert to command priv_size usage Nicholas A. Bellinger
2013-08-31 2:52 ` [PATCH-v5 6/6] iscsi-target: Convert to per-cpu ida_alloc + ida_free command map Nicholas A. Bellinger
2013-09-03 16:04 ` [PATCH-v5 0/6] target/vhost/iscsi: Add per-cpu ida tag pre-allocation for v3.12 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903182749.21052ab6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=asias@redhat.com \
--cc=axboe@kernel.dk \
--cc=cl@gentwo.org \
--cc=cl@linux-foundation.org \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=oleg@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.