From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next] bcm87xx: Add MODULE_DEVICE_TABLE Date: Tue, 3 Sep 2013 19:53:05 +0100 Message-ID: <20130903185305.GC7729@decadent.org.uk> References: <1378071184.25743.52.camel@deadeye.wl.decadent.org.uk> <52261D12.5000009@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , David Daney , netdev To: David Daney Return-path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:39406 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770Ab3ICSxK (ORCPT ); Tue, 3 Sep 2013 14:53:10 -0400 Content-Disposition: inline In-Reply-To: <52261D12.5000009@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Sep 03, 2013 at 10:32:02AM -0700, David Daney wrote: > On 09/01/2013 02:33 PM, Ben Hutchings wrote: > >bcm87xx currently isn't auto-loaded if built as a module. > > > >Signed-off-by: Ben Hutchings > >--- > >Compile-tested only. > > Then how do you know that it does anything sensible? This is generally required in modular PHY drivers. I was hoping you'd be able to say whether that it's useful or necessary for this one. > Other than that, it seems plausible. > > David Daney Thanks. Ben. > > > >Ben. > > > > drivers/net/phy/bcm87xx.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > >diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c > >index 7997895..f5b44ff 100644 > >--- a/drivers/net/phy/bcm87xx.c > >+++ b/drivers/net/phy/bcm87xx.c > >@@ -230,4 +230,11 @@ static void __exit bcm87xx_exit(void) > > } > > module_exit(bcm87xx_exit); > > > >+static struct mdio_device_id __maybe_unused bcm87xx_tbl[] = { > >+ { PHY_ID_BCM8706, 0xffffffff }, > >+ { PHY_ID_BCM8727, 0xffffffff }, > >+ { } > >+}; > >+ > > MODULE_LICENSE("GPL"); > >+MODULE_DEVICE_TABLE(mdio, bcm87xx_tbl); > > > -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus