From: William Dauchy <william@gandi.net>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: William Dauchy <wdauchy@gmail.com>,
Linux NFS mailing list <linux-nfs@vger.kernel.org>,
"Adamson, Andy" <William.Adamson@netapp.com>,
William Dauchy <william@gandi.net>
Subject: Re: [PATCH v2] NFS: Ensure that rmdir() waits for sillyrenames to complete
Date: Tue, 3 Sep 2013 22:44:31 +0200 [thread overview]
Message-ID: <20130903204431.GF22430@gandi.net> (raw)
In-Reply-To: <1378234234.6410.36.camel@leira.trondhjem.org>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Sep03 18:50, Myklebust, Trond wrote:
> Thanks again for testing! Does the following fixup on top of the 'v2'
> patch also help?
> --- a/fs/nfs/unlink.c
> +++ b/fs/nfs/unlink.c
> @@ -211,7 +211,7 @@ void nfs_wait_on_sillyrename(struct dentry *dentry)
> {
> struct nfs_inode *nfsi = NFS_I(dentry->d_inode);
>
> - wait_event(nfsi->waitqueue, atomic_read(&nfsi->silly_count) == 1);
> + wait_event(nfsi->waitqueue, atomic_read(&nfsi->silly_count) <= 1);
> }
>
> void nfs_block_sillyrename(struct dentry *dentry)
hmmm I just realized your v2 version had `== 1`; in fact I tested your v1
with `== 0`. Let me some time to retest the v2.
Thanks,
--
William
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-09-03 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 18:17 [PATCH v2] NFS: Ensure that rmdir() waits for sillyrenames to complete Trond Myklebust
2013-09-03 9:33 ` William Dauchy
2013-09-03 18:50 ` Myklebust, Trond
2013-09-03 20:44 ` William Dauchy [this message]
2013-09-03 20:47 ` Myklebust, Trond
2013-09-04 9:19 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903204431.GF22430@gandi.net \
--to=william@gandi.net \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=wdauchy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.