All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/3] USB: gadget: add atmel usba udc driver
Date: Wed, 4 Sep 2013 03:55:06 +0200	[thread overview]
Message-ID: <201309040355.06964.marex@denx.de> (raw)
In-Reply-To: <52268F0F.7080102@atmel.com>

Dear Bo Shen,

> Hi Marek Vasut,
> 
> On 09/04/2013 06:30 AM, Marek Vasut wrote:
> > Dear Bo Shen,
> > 
> >> Add atmel usba udc driver support, porting from Linux kernel
> >> 
> >> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> > 
> > Please see [1] , point 4. I miss the exact point in Linux kernel history
> > (read commit hash) from which this code was imported at least.
> > 
> > [1]
> > http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_
> > Sign
> 
> Thanks.
> 
> I will add this information into v2 after you finish reviewing the code.
> 
> The original code information from Linux kernel as following
> ---8>---
> commit e01ee9f509a927158f670408b41127d4166db1c7
> Author: Jingoo Han <jg1.han@samsung.com>
> Date:   Tue Jul 30 17:00:51 2013 +0900
> 
>      usb: gadget: use dev_get_platdata()
> 
>      Use the wrapper function for retrieving the platform data instead of
>      accessing dev->platform_data directly.
> 
>      Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>      Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---<8---
> 

The code looks pretty much OK.

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-04  1:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03  3:47 [U-Boot] [RFC PATCH 0/3] USB: atmel: add atmel usba udc driver support Bo Shen
2013-09-03  3:47 ` [U-Boot] [RFC PATCH 1/3] USB: gadget: add atmel usba udc driver Bo Shen
2013-09-03 22:30   ` Marek Vasut
2013-09-04  1:38     ` Bo Shen
2013-09-04  1:55       ` Marek Vasut [this message]
2013-09-03  3:47 ` [U-Boot] [RFC PATCH 2/3] ARM: atmel: correct UDPHS name Bo Shen
2013-09-03  3:47 ` [U-Boot] [RFC PATCH 3/3] ARM: atmel: add RNDIS gadget support Bo Shen
2013-09-03 22:31   ` Marek Vasut
2013-09-04  1:46     ` Bo Shen
2013-09-04  1:55       ` Marek Vasut
2013-09-04  2:01         ` Bo Shen
2013-09-04  7:32           ` Andreas Bießmann
2013-09-04  7:42             ` Bo Shen
2013-09-04  7:56               ` Andreas Bießmann
2013-09-04 12:25                 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309040355.06964.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.