All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] ia64 builds fails (and maybe alpha too?)
Date: Wed, 04 Sep 2013 10:32:59 +0300	[thread overview]
Message-ID: <20130904073258.GA2616@swordfish> (raw)
In-Reply-To: 52266C26.4070705@linux.intel.com

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

On (09/03/13 16:09), Arjan van de Ven wrote:
> >g++ -DHAVE_CONFIG_H -I. -I..  -D_FORTIFY_SOURCE=2
> >- -I/usr/include/libnl3     -DLOCALEDIR=\"/usr/share/locale\"
> >- -D_FORTIFY_SOURCE=2 -fno-omit-frame-pointer -fstack-protector -Wall
> >- -Wshadow -Wformat   -I/usr/include/libnl3    -g -O2 -Wformat
> >- -Werror=format-security -c -o perf/powertop-perf.o `test -f
> >'perf/perf.cpp' || echo './'`perf/perf.cpp
> >perf/perf.cpp:1:0: warning: -fstack-protector not supported for this
> >target [enabled by default]
> >perf/perf.cpp: In function 'int sys_perf_event_open(perf_event_attr*,
> >pid_t, int, int, long unsigned int)':
> >perf/perf.cpp:67:17: error: '__NR_perf_event_open' was not declared in
> >this scope
> >perf/perf.cpp:69:1: warning: control reaches end of non-void function
> >[-Wreturn-type]
> >make[4]: *** [perf/powertop-perf.o] Error 1
> >make[3]: *** [all] Error 2
> >```
> 
> if your kernel does not have "perf", there is no point in using powertop....
> really; it will not work at all.
> 
> (including anything asm-generic/foo also is the wrong answer; that directory is not architectural
> from a kernel perspective, only for indirect inclusion)
> 

we had this workaround some time ago, it was removed by

commit 9ce9ec662ce7b642967fd75222114b624b8a503a
Author: Chris E Ferron <chris.e.ferron(a)linux.intel.com>
Date:   Fri Jul 20 15:14:08 2012 -0700

    removed re-define of __NR_perf_event_open, what was needed for stale
    headers in older kernels. sys/syscall.h will not be correct.


-/* __NR_perf_event_open in ia64 and alpha is defined elsewhere */
-#ifdef __ia64__
-#include <asm-generic/unistd.h>
-#endif


	-ss

             reply	other threads:[~2013-09-04  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04  7:32 Sergey Senozhatsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-09-04 14:52 [Powertop] ia64 builds fails (and maybe alpha too?) Arjan van de Ven
2013-09-04  8:40 Sergey Senozhatsky
2013-09-03 23:18 Jose Luis Rivas
2013-09-03 23:09 Arjan van de Ven
2013-09-03 23:04 Jose Luis Rivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904073258.GA2616@swordfish \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.