All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] SVN process started at make
Date: Wed, 4 Sep 2013 10:07:54 +0200	[thread overview]
Message-ID: <20130904100754.297bb0d6@skate> (raw)
In-Reply-To: <15AE5A936F5E3A42A9144E66875A0A8934DB3E@server1-derijp.CLB-Benelux.lokaal>

Dear Ruud Commandeur,

On Wed, 4 Sep 2013 09:55:50 +0200, Ruud Commandeur wrote:

> Thanks for your reply. This does indeed seem to be the cause. If I make
> this change to the top-level Makefile:
> 
> # Compute the full local version string so packages can use it as-is
> # Need to export it, so it can be got from environment in children (eg.
> mconf)
> -export BR2_VERSION_FULL:=$(BR2_VERSION)$(shell
> $(TOPDIR)/support/scripts/setlocalversion)
> +export BR2_VERSION_FULL:=$(BR2_VERSION)
> 
> things are back to normal.
> 
> Am I correct, that what this setlocalversion does, is add a revision
> mark to the version string? Does it run that for each file to be
> processed (since it can take that long)? For my build it reports
> "2013.02-svn9-dirty". So it seems to check only a number of files and/or
> folders, since the trunk is at revision 84 now, but some folders are
> indeed at 9.

You can check what this script is doing by looking at it in
support/scripts/setlocalversion. For SVN, it does:

# Check for svn and a svn repo.
if rev=`LC_ALL=C svn info 2>/dev/null | grep '^Last Changed Rev'`; then
        rev=`echo $rev | awk '{print $NF}'`
        changes=`LC_ALL=C svn status 2>/dev/null | grep '^[AMD]' | wc -l`

        # Are there uncommitted changes?
        if [ $changes != 0 ]; then
                printf -- '-svn%s%s' "$rev" -dirty
        else
                printf -- '-svn%s' "$rev"
        fi

        # All done with svn
        exit
fi

So there are two svn commands, and it normally does them only *once*
per build (i.e per invocation of make).

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-09-04  8:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 14:37 [Buildroot] SVN process started at make Ruud Commandeur
2013-09-03 14:50 ` Peter Korsgaard
2013-09-03 16:28   ` Arnout Vandecappelle
2013-09-04  7:55     ` Ruud Commandeur
2013-09-04  8:07       ` Thomas Petazzoni [this message]
2013-09-04  8:57         ` Ruud Commandeur
2013-09-04  9:15           ` Peter Korsgaard
2013-09-04 10:02             ` Peter Korsgaard
2013-09-04 11:49               ` Ruud Commandeur
2013-09-04 11:26             ` Ruud Commandeur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904100754.297bb0d6@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.