From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet
Date: Wed, 4 Sep 2013 14:57:32 +0200 [thread overview]
Message-ID: <20130904125732.GA4542@localhost> (raw)
In-Reply-To: <20130901153221.GB10125@linuxace.com>
On Sun, Sep 01, 2013 at 08:32:21AM -0700, Phil Oester wrote:
> In commit b396966c4 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
> I attempted to add safe fragment handling to xt_TCPMSS. However, Andy Padavan
> of Project N56U correctly points out that returning XT_CONTINUE in this
> function does not work. The callers (tcpmss_tg[46]) expect to receive a value
> of 0 in order to return XT_CONTINUE.
Applied, thanks Phil.
prev parent reply other threads:[~2013-09-04 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 15:32 [PATCH] netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet Phil Oester
2013-09-04 12:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904125732.GA4542@localhost \
--to=pablo@netfilter.org \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.