From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Cc: Larry.Finger@lwfinger.net
Subject: rtl8188eu array/null comparison.
Date: Wed, 4 Sep 2013 19:30:18 -0400 [thread overview]
Message-ID: <20130904233018.GB5727@redhat.com> (raw)
Hi Larry,
in drivers/staging/rtl8188eu/core/rtw_mlme.c:rtw_check_join_candidate there's this code..
1721 /* check ssid, if needed */
1722 if (pmlmepriv->assoc_ssid.Ssid && pmlmepriv->assoc_ssid.SsidLength) {
1723 if (competitor->network.Ssid.SsidLength != pmlmepriv->assoc_ssid.SsidLength ||
1724 _rtw_memcmp(competitor->network.Ssid.Ssid, pmlmepriv->assoc_ssid.Ssid, pmlmepriv->assoc_ssid.SsidLength) == false)
1725 goto exit;
1726 }
1727
assoc_ssid.Ssid being an array, this comparison against null probably isn't what was intended ?
Dave
next reply other threads:[~2013-09-04 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 23:30 Dave Jones [this message]
2013-09-05 3:14 ` rtl8188eu array/null comparison Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904233018.GB5727@redhat.com \
--to=davej@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.