Re: [PATCH] ksm: Remove redundant __GFP_ZERO from kcalloc

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Thu, Aug 29, 2013 at 04:32:14PM -0700, Joe Perches wrote:
>kcalloc returns zeroed memory.
>There's no need to use this flag.
>

Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

>Signed-off-by: Joe Perches <joe@perches.com>
>---
> mm/ksm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mm/ksm.c b/mm/ksm.c
>index 0bea2b2..175fff7 100644
>--- a/mm/ksm.c
>+++ b/mm/ksm.c
>@@ -2309,8 +2309,8 @@ static ssize_t merge_across_nodes_store(struct kobject *kobj,
> 			 * Allocate stable and unstable together:
> 			 * MAXSMP NODES_SHIFT 10 will use 16kB.
> 			 */
>-			buf = kcalloc(nr_node_ids + nr_node_ids,
>-				sizeof(*buf), GFP_KERNEL | __GFP_ZERO);
>+			buf = kcalloc(nr_node_ids + nr_node_ids, sizeof(*buf),
>+				      GFP_KERNEL);
> 			/* Let us assume that RB_ROOT is NULL is zero */
> 			if (!buf)
> 				err = -ENOMEM;
>-- 
>1.8.1.2.459.gbcd45b4.dirty
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>