Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 5 Sep 2013 17:53:38 +0000
"Nelson, Shannon" <shannon.nelson@intel.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Wednesday, September 04, 2013 5:38 PM
> 
> [...]
> 
> > Also, anything in sysfs is device specific and you really need to make
> > a strong case for why your device is special and needs an exception.
> > Other devices will have hardware switches and doing something through
> > sysfs is going to create a pain for any controller application.
> > 
> > I vote against including the sysfs VEB stuff because it will become
> > a lifetime ABI.
> 
> If we simply remove the VEB attributes (cvlan, mode, seid, svlan) but keep the model structure and the VSI attributes, will that satisfy your vote, or are you suggesting that we should drop the whole sysfs model that we implemented?
> 
> At this point after some discussion internally, we think it would be better to simply remove the whole sysfs module - it is an optional section with no direct operational requirement.  The intent was to get something started that looked useful, but perhaps we were a little premature in presenting this model for these new switch offload capabilities.
> 
> As Dave rightly pointed out, we may want to bring this back in the future, but I think that we have more work to do with the community in proposing and designing a switching model, if it really is even needed.  That's not an over-night thing, and we shouldn't be trying to patch up something that has fundamental concerns.  Also, bringing it back later when it isn't obscured by the rest of the driver might be more successful in getting community input.
> 
> sln
> 
> 

IMHO  attributes are a nice way of handling the VSI attributes since they
seem hardware specific.  Not sure how to do the right thing with switching.
Should it look like Macvlan, bridge, VXLAN, or something else.